Skip to content

feat(runtime-vapor): use css vars work with vapor mode #12621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 718 commits into
base: minor
Choose a base branch
from
Open

feat(runtime-vapor): use css vars work with vapor mode #12621

wants to merge 718 commits into from

Conversation

edison1105
Copy link
Member

@edison1105 edison1105 commented Dec 26, 2024 •
edited
Loading

  • Added a new runtime-helper vaporUseCssVars
  • Extracted baseUseCssVars from the existing useCssVars function for reuse in runtime-vapor
    • (1)Included the logic for applying CSS vars in Teleport
    • (2)Included instance.getCssVars for hydration mismatch checks

Not sure if (1) and (2) can be fully reused, but I think they can, so kept them inside baseUseCssVars

LittleSound and others added 30 commits May 21, 2024 08:43
@LittleSound
test(vue-vapor): todomvc e2e test (#115)
2e2f3e2
@Doctor-wu @LittleSound @sxzz
feat(compiler/runtime-vapor): implement v-slots + v-for / v-if (#207)
4e13a57 
Co-authored-by: Rizumu Ayaka <[email protected]>
Co-authored-by: 三咲智子 Kevin Deng <[email protected]>
@sxzz
ci: fix RCE vulnerability in file overwrite
1008199 
#10985

Special thanks to @redyetidev
@ubugeeei @sxzz
test(runtime-vapor): api lifecycle hooks (#215)
969f53f 
Co-authored-by: 三咲智子 Kevin Deng <[email protected]>
@LittleSound @sxzz
feat: directive lifecycle hooks in v-for, v-if and component (#123)
b5ecb72 
Co-authored-by: 三咲智子 Kevin Deng <[email protected]>
@shellingfordly @sxzz
fix(playground): import type error (#219)
ca61022 
Co-authored-by: 三咲智子 Kevin Deng <[email protected]>
@sxzz
refactor(compiler-vapor): remove Object.entries
c97dee3
@sxzz
fix(vue-vapor): build dts
4ed4fb6
@Doctor-wu
feat(runtime-vapor): resolve assets of components & directives (#214)
107569b
@sxzz
refactor(compiler-vapor): inline literal value into template
00c6e6d
@LittleSound @sxzz
feat: destructuring + nesting in v-for (#217)
868c429 
Co-authored-by: 三咲智子 Kevin Deng <[email protected]>
@sxzz
Merge remote-tracking branch 'upstream/minor'
334e72e
@sxzz
refactor: remove optional chaining
5a0a2bf
@LittleSound
refactor: general destructuring function (#221)
b2259a5
@sxzz
fix(compiler-sfc): vapor attribute on template tag
cef446a
@LittleSound @sxzz
feat(compiler-vapor): v-slot props + v-slot on component (#223)
208dbc6 
Co-authored-by: 三咲智子 Kevin Deng <[email protected]>
@Doctor-wu
perf(compiler-vapor/runtime-vapor): finer update granularity (#222)
8a59311
@Doctor-wu
refactor(compiler/runtime-vapor): remove unnecessary slot key (#225)
8ccfce5
@sxzz
test(runtime-vapor): finish createVaporApp unit tests
bbd1944
@sxzz
test(runtime-vapor): finish expose and inject tests
598b55f
@sxzz
test(compiler-vapor): add scopeId test
b023b9b
@LittleSound
feat(runtime-vapor): slot props (#227)
c9241da
@sxzz
chore: update readme
325eb13
@sxzz
fix(runtime-vapor): infer component name from registry
a1797f8
@Doctor-wu
test(runtime-vapor): fix type (#229)
ad3d8fa
@xiaodong2008 @sxzz
feat(runtime-vapor): implement app.config.performance (#230)
3ac951b 
* feat(runtime-capor): add app.config.performance

* refactor: move formatComponentName to component.ts

* refactor: update import in warning.ts

* fix

* refactor

* fix order

---------

Co-authored-by: 三咲智子 Kevin Deng <[email protected]>
@sxzz
Merge remote-tracking branch 'upstream/minor'
cf8be99
@Doctor-wu
test(runtime-vapor): add directive test case (#231)
80acfa5
@xiaodong2008 @sxzz
test(runtime-vapor): add unit test for config.performance (#234)
bc04592 
Co-authored-by: 三咲智子 Kevin Deng <[email protected]>
@xiaodong2008 @sxzz
test(runtime-vapor): add apiSetupContext unit test (#237)
bbde386 
Co-authored-by: 三咲智子 Kevin Deng <[email protected]>
yyx990803 and others added 20 commits December 11, 2024 16:43
@yyx990803
ci: fix continuous release vapor skip
badd995
@yyx990803
wip: cache setProp prev value on element, simplify codegen
dfe06f8 
Also separate `setClass`/`setClassIncremental` and `setStyle`/
`setStyleIncremental`
@yyx990803
wip: refactor vapor vBind codegen
4505727
@yyx990803
chore: remove no longer needed file
c4b853d
@yyx990803
chore: fix setStyle and tests
e388053
@yyx990803
wip(vapor): templateRef adjustments
0d1df25
@yyx990803
test(vapor): useTemplateRef tests
023f72f
@yyx990803
test(vapor): fix templateRef compiler tests
4160b6d
@yyx990803
wip(vapor): handle class / style merging behavior
f9a6e8c
@yyx990803
wip(vapor): further tweak single root attr fallthrough behavior
c07734d
@yyx990803
wip(vapor): init feature flags + set devtools when creating vapor app
76e8d2c
@yyx990803
wip(vapor): optimize unmounted children removal
bcb9209
@yyx990803
wip(vapor): createIf
4318129
@yyx990803
wip(vapor): handle slot fallback when content changes
6c0e8a8
@edison1105
fix(vapor/defineProps): register type bindings before compile templat…
e79a6df 
…e + props destructure work with vapor (#12545)
@edison1105
refactor(vapor): import v-o withModifiers or withKeys on demand (#12539)
bd13001
@edison1105
refactor(compiler-vapor): move operation with constant values out of …
ef6986f 
…renderEffect (#12547)
@edison1105
refactor(cssVars): use css vars work with vapor mode
2895e1a
@edison1105
wip: save
d925595
@edison1105
wip: re-use more logic
a3f719d
@edison1105 edison1105 force-pushed the edison/refactor/vaporUseCssVars branch from dfacf7d to a3f719d Compare December 27, 2024 05:58
@edison1105 edison1105 force-pushed the edison/refactor/vaporUseCssVars branch from e399800 to f6ef75c Compare December 27, 2024 07:19
@edison1105 edison1105 marked this pull request as ready for review December 27, 2024 07:31
@edison1105 edison1105 changed the title feat(cssVars): use css vars work with vapor mode feat(runtime-vapor): use css vars work with vapor mode Dec 27, 2024
@edison1105 edison1105 added the scope: vapor related to vapor mode label Dec 30, 2024
Base automatically changed from vapor to minor July 7, 2025 00:06
@edison1105 edison1105 mentioned this pull request Jul 21, 2025
Open
@edison1105 edison1105 linked an issue Jul 21, 2025 that may be closed by this pull request
[Vapor] useCssVars (style v-bind) doesn't work with vapor #13666
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
scope: vapor related to vapor mode
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Vapor] useCssVars (style v-bind) doesn't work with vapor