fix(apiOptions): invalid computed option #225
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a631807682
changed the title
a631807682
changed the title
pikax
reviewed
Oct 12, 2019
| @@ -539,7 +539,7 @@ describe('api: options', () => { | |||
| expect('Invalid watch option: "foo"').toHaveBeenWarned() | |||
| }) | |||
|
|
|||
| test('computed warn with setter and no getter', () => { | |||
| test('computed with setter and no getter', () => { | |||
There was a problem hiding this comment.
I think the previous description is a bit better describing what the test is
There was a problem hiding this comment.
I think the previous description is a bit better describing what the test is
but it wrapped in warnings describe, so i have no idea which is better.
yyx990803
requested changes
Oct 12, 2019
|
Hey @a631807682, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚 |
sxzz
pushed a commit
that referenced
this pull request
Aug 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.