Skip to content

Release 20.0 ci fixes#20179

Closed
arthurschreiber wants to merge 209 commits into
vitessio:mainfrom
arthurschreiber:release-20.0-ci-fixes
Closed

Release 20.0 ci fixes#20179
arthurschreiber wants to merge 209 commits into
vitessio:mainfrom
arthurschreiber:release-20.0-ci-fixes

Conversation

@arthurschreiber
Copy link
Copy Markdown
Member

@arthurschreiber arthurschreiber commented May 26, 2026

Description

Related Issue(s)

Checklist

  • "Backport to:" labels have been added if this change should be back-ported to release branches
  • If this change is to be back-ported to previous releases, a justification is included in the PR description
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

Deployment Notes

AI Disclosure

vitess-bot Bot and others added 30 commits June 4, 2024 18:35
@vitess-bot
[release-20.0] Add DCO workflow (vitessio#16052) (vitessio#16058)
7cc151c 
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>
@vitess-bot @frouioui
[release-20.0] Upgrade the Golang version to go1.22.4 (vitessio#16060)
83c14fa 
Signed-off-by: GitHub <noreply@github.com>
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Co-authored-by: frouioui <frouioui@users.noreply.github.com>
Co-authored-by: Florent Poinsard <florent.poinsard@outlook.fr>
@vitess-bot
[release-20.0] Changelog 20.0: Fix broken links (vitessio#16048) (vit…
be83207 
…essio#16076)

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>
@shlomi-noach @frouioui
v20 backport: CI upgrade/downgrade tests for Online DDL / throttler /…
e0bbefc 
… vreplication flow (vitessio#16065)

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Co-authored-by: Florent Poinsard <35779988+frouioui@users.noreply.github.com>
@vitess-bot
[release-20.0] Remove DCO workaround (vitessio#16087) (vitessio#16093)
b938e7e 
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>
@vitess-bot
[release-20.0] Do not load table stats when booting vttablet. (vite…
b16adf7 
…ssio#15715) (vitessio#16101)

Signed-off-by: Arthur Schreiber <arthurschreiber@github.com>
Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>
@vitess-bot
[release-20.0] Update braces package (vitessio#16115) (vitessio#16120)
f683028 
Signed-off-by: Frances Thai <notfelineit@gmail.com>
Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>
@vitess-bot
[release-20.0] vtctldclient: Apply (Shard | Keyspace| Table) Routing …
a8932cd 
…Rules commands don't work (vitessio#16096) (vitessio#16126)

Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>
@vitess-bot
[release-20.0] VReplication: Improve workflow cancel/delete (vitessio…
82454d4 
…#15977) (vitessio#16131)

Signed-off-by: Matt Lord <mattalord@gmail.com>
Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>
@vitess-bot @systay @frouioui
[release-20.0] fix: order by subquery planning (vitessio#16049) (vite…
d50d290 
…ssio#16134)

Signed-off-by: Andres Taylor <andres@planetscale.com>
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>
Co-authored-by: Andres Taylor <andres@planetscale.com>
Co-authored-by: Florent Poinsard <florent.poinsard@outlook.fr>
@shlomi-noach
[release-20.0] Copy v20.0.0-RC1 release notes (vitessio#16141)
f88503c 
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
@vitess-bot
[release-20.0] Fix vtexplain not handling UNION queries with `wei…
fdbafd9 
…ght_string` results correctly. (vitessio#16129) (vitessio#16158)

Signed-off-by: Arthur Schreiber <arthurschreiber@github.com>
Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>
@vitess-bot
[release-20.0] CI Bug: Rename shard name back to match existing workf…
9f57ff8 
…low file for vreplication_migrate_vdiff2_convert_tz (vitessio#16148) (vitessio#16151)

Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>
@vitess-bot
[release-20.0] Docker: Update node vtadmin version (vitessio#16147) (v…
545e69d 
…itessio#16161)

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>
@vitess-bot
[release-20.0] Fix flakiness in vtexplain unit test case. (vitessio…
d616ba1 
…#16159) (vitessio#16168)

Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>
@GuptaManan100
[release-20.0] CI Summary Addition (vitessio#16172)
ba19342 
Signed-off-by: Manan Gupta <manan@planetscale.com>
@vitess-bot @mattlord
[release-20.0] CI flaky test: Fix flakiness in vreplication_migrate_v…
d2d60be 
…diff2_convert_tz (vitessio#16180) (vitessio#16189)

Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Signed-off-by: Matt Lord <mattalord@gmail.com>
Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>
Co-authored-by: Matt Lord <mattalord@gmail.com>
@vitess-bot
[release-20.0] feat: add a LIMIT 1 on EXISTS subqueries to limit netw…
4baa524 
…ork overhead (vitessio#16153) (vitessio#16193)

Signed-off-by: Andres Taylor <andres@planetscale.com>
Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>
@vitess-bot
[release-20.0] fix: rows affected count for multi table update for no…
9c60e9d 
…n-literal column value (vitessio#16181) (vitessio#16183)

Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>
@vitess-bot @frouioui
[release-20.0] Handle Nullability for Columns from Outer Tables (vite…
25f6f72 
…ssio#16174) (vitessio#16187)

Signed-off-by: Andres Taylor <andres@planetscale.com>
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>
Co-authored-by: Florent Poinsard <florent.poinsard@outlook.fr>
@vitess-bot
[release-20.0] VDiff CLI: Fix VDiff show bug (vitessio#16177) (vite…
b3b64a1 
…ssio#16200)
@vitess-bot
[release-20.0] Online DDL shadow table: rename referenced table name …
6c591bd 
…in self referencing FK (vitessio#16205) (vitessio#16209)

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>
@vitess-bot
[release-20.0] Fix flaky tests that use vtcombo (vitessio#16178) (vit…
2c9e5dd 
…essio#16213)

Signed-off-by: Manan Gupta <manan@planetscale.com>
Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>
@vitess-bot
[release-20.0] Remove unnecessary Docker build workflows (vitessio#16196
e5dd319 
) (vitessio#16202)

Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>
@vitess-bot
[release-20.0] VReplication: handle escaped identifiers in vschema wh…
cfe278e 
…en initializing sequence tables (vitessio#16169) (vitessio#16219)

Signed-off-by: Matt Lord <mattalord@gmail.com>
Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>
@vitess-bot
[release-20.0] VReplication Workflow: set state correctly when restar…
87337d6 
…ting workflow streams in the copy phase (vitessio#16217) (vitessio#16224)

Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>
@shlomi-noach
[release-20.0] Copy v20.0.0-RC2 release notes (vitessio#16235)
b4f53dc 
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
@vitess-bot
[release-20.0] release notes: update dml related release notes (vites…
54c4abe 
…sio#16241) (vitessio#16247)

Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>
@GuptaManan100
[release-20.0] Fix vtgate crash in group concat (vitessio#16252)
15a66d5 
Signed-off-by: Manan Gupta <manan@planetscale.com>
@vitess-bot
[release-20.0] Release docs: Add vreplication related entries to the …
f8604f2 
…v20 summary (vitessio#16259) (vitessio#16271)

Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>
Copilot AI reviewed May 26, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review this pull request because it exceeds the maximum number of files (300). Try reducing the number of changed files and requesting a review from Copilot again.

@github-actions github-actions Bot added this to the v25.0.0 milestone May 26, 2026
@vitess-bot vitess-bot Bot added NeedsWebsiteDocsUpdate What it says NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels May 26, 2026
@vitess-bot
Copy link
Copy Markdown
Contributor

vitess-bot Bot commented May 26, 2026

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@harshit-gangal harshit-gangal Awaiting requested review from harshit-gangal harshit-gangal is a code owner

@mattlord mattlord Awaiting requested review from mattlord mattlord is a code owner

@beingnoble03 beingnoble03 Awaiting requested review from beingnoble03 beingnoble03 is a code owner

@frouioui frouioui Awaiting requested review from frouioui frouioui is a code owner

@rohit-nayak-ps rohit-nayak-ps Awaiting requested review from rohit-nayak-ps rohit-nayak-ps is a code owner

@shlomi-noach shlomi-noach Awaiting requested review from shlomi-noach shlomi-noach is a code owner

@derekperkins derekperkins Awaiting requested review from derekperkins derekperkins is a code owner

@systay systay Awaiting requested review from systay systay is a code owner

@timvaillancourt timvaillancourt Awaiting requested review from timvaillancourt timvaillancourt is a code owner

@dbussink dbussink Awaiting requested review from dbussink dbussink is a code owner

Assignees

No one assigned

Labels

Component: Build/CI Component: Docker Component: Documentation docs related issues/PRs Component: Evalengine changes to the evaluation engine Component: Examples Component: Java Pull requests that update Java code Component: Messaging Component: Online DDL Online DDL (vitess/native/gh-ost/pt-osc) Component: TabletManager Component: Throttler Component: Topology Component: VDiff Component: VTAdmin VTadmin interface Component: vtctldclient Component: vtexplain changes made to vtexplain code Component: VTGate Component: VTOrc Vitess Orchestrator integration Component: VTTablet NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says Type: Dependencies Dependency updates

Projects

None yet

Milestone

v25.0.0

Development

Successfully merging this pull request may close these issues.