fix: rows affected count for multi table update for non-literal column value#16181
Merged
Merged
Conversation
…n value Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Contributor
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
GuptaManan100
approved these changes
Jun 14, 2024
dbussink
approved these changes
Jun 14, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #16181 +/- ##
==========================================
+ Coverage 68.54% 68.56% +0.02%
==========================================
Files 1544 1544
Lines 197737 197737
==========================================
+ Hits 135532 135583 +51
+ Misses 62205 62154 -51 ☔ View full report in Codecov by Sentry. |
systay
reviewed
Jun 14, 2024
| res = qr | ||
| } else { | ||
| res.RowsAffected += res.RowsAffected | ||
| res.RowsAffected += qr.RowsAffected |
systay
approved these changes
Jun 14, 2024
vitess-bot
pushed a commit
that referenced
this pull request
Jun 14, 2024
…n value (#16181) Signed-off-by: Harshit Gangal <harshit@planetscale.com>
vitess-bot
pushed a commit
that referenced
this pull request
Jun 14, 2024
…n value (#16181) Signed-off-by: Harshit Gangal <harshit@planetscale.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the calculation for rows affected for a update query with multi table when a column is updated with non-literal value.
Related Issue(s)
Checklist
Deployment Notes