Skip to content

onlineddl: e2e test for REVERT VITESS_MIGRATION completing on both shards #20176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
shlomi-noach wants to merge 1 commit into
base: main
Choose a base branch
from
+29 −0
Open

onlineddl: e2e test for REVERT VITESS_MIGRATION completing on both shards #20176

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 29 additions & 0 deletions go/test/endtoend/onlineddl/vrepl/onlineddl_vrepl_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -857,6 +857,35 @@ func TestVreplSchemaChanges(t *testing.T) {
}
})
})
t.Run("Revert a migration completed on both shards", func(t *testing.T) {
var uuid string
t.Run("run migration, expect completion on both shards", func(t *testing.T) {
uuid = testOnlineDDLStatement(t, alterTableTrivialStatement, "vitess", providedUUID, providedMigrationContext, "vtgate", "test_val", "", false)
onlineddl.CheckMigrationStatus(t, &vtParams, shards, uuid, schema.OnlineDDLStatusComplete)
})
var revertUUID string
t.Run("issue revert migration", func(t *testing.T) {
revertQuery := fmt.Sprintf("revert vitess_migration '%s'", uuid)
output, err := clusterInstance.VtctldClientProcess.ApplySchemaWithOutput(keyspaceName, revertQuery, cluster.ApplySchemaParams{DDLStrategy: "vitess"})
require.NoError(t, err)
revertUUID = strings.TrimSpace(output)
assert.NotEmpty(t, revertUUID)
})
t.Run("revert completes on both shards", func(t *testing.T) {
status := onlineddl.WaitForMigrationStatus(t, &vtParams, shards, revertUUID, normalMigrationWait, schema.OnlineDDLStatusComplete, schema.OnlineDDLStatusFailed)
fmt.Printf("# Migration status (for debug purposes): <%s>\n", status)
onlineddl.CheckMigrationStatus(t, &vtParams, shards, revertUUID, schema.OnlineDDLStatusComplete)
})
t.Run("validate both shards show complete in SHOW VITESS_MIGRATIONS", func(t *testing.T) {
rs := onlineddl.ReadMigrations(t, &vtParams, revertUUID)
require.NotNil(t, rs)
require.Equal(t, 2, len(rs.Rows))
for _, row := range rs.Named().Rows {
status := row["migration_status"].ToString()
assert.Equal(t, string(schema.OnlineDDLStatusComplete), status, "shard %s", row["shard"].ToString())
}
})
})
t.Run("summary: validate sequential migration IDs", func(t *testing.T) {
onlineddl.ValidateSequentialMigrationIDs(t, &vtParams, shards)
})
Expand Down
Loading