onlineddl: e2e test for REVERT VITESS_MIGRATION completing on both shards#20176
Open
shlomi-noach wants to merge 1 commit into
Open
onlineddl: e2e test for REVERT VITESS_MIGRATION completing on both shards#20176shlomi-noach wants to merge 1 commit into
REVERT VITESS_MIGRATION completing on both shards#20176shlomi-noach wants to merge 1 commit into
Conversation
Adds a sub-test to TestVreplSchemaChanges that verifies a REVERT VITESS_MIGRATION submitted via vtctldclient completes successfully on both shards of the 2-shard cluster, exercising the keyspace-level fanout path end-to-end. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Contributor
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
Contributor
There was a problem hiding this comment.
Pull request overview
Adds an end-to-end “happy path” coverage to the existing 2-shard OnlineDDL VReplication e2e suite to ensure REVERT VITESS_MIGRATION completes successfully on both shards when the original migration completed on both shards.
Changes:
- Add a new subtest that runs an OnlineDDL migration to completion on both shards.
- Issue
REVERT VITESS_MIGRATIONviavtctldclient ApplySchemaand wait for completion across both shards. - Assert
SHOW VITESS_MIGRATIONSreturns exactly two rows (one per shard) and both arecompletefor the revert UUID.
mattlord
approved these changes
May 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a test to a behavior we know is correct, and is true in general for all
ApplySchemaoperation, but just making it very explicit now.Adds a follow-up sub-test to
TestVreplSchemaChanges(the only e2e suite that runs on a 2-shard cluster) covering the happy path for revert: a migration completes on both shards, aREVERT VITESS_MIGRATIONis issued via vtctldclient, and the revert completes successfully on both shards.The existing sibling test ("Revert a migration completed on one shard and cancelled on another") covers the failure case where revert is impossible on one shard. This PR adds the complementary success case.
Verification
WaitForMigrationStatususes the fullshardsslice — the wait only returns when both shards reach terminal statusReadMigrationsasserts exactly 2 rows, bothcomplete, with the shard name surfaced in any failure message