Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -280,7 +280,7 @@ $(PROTO_GO_OUTS): minimaltools install_protoc-gen-go proto/*.proto
# This rule builds the bootstrap images for all flavors.
DOCKER_IMAGES_FOR_TEST = mysql80 mysql84 percona80
DOCKER_IMAGES = common $(DOCKER_IMAGES_FOR_TEST)
BOOTSTRAP_VERSION=48.3
BOOTSTRAP_VERSION=48.4
ensure_bootstrap_version:
find docker/ -type f -exec sed -i "s/^\(ARG bootstrap_version\)=.*/\1=${BOOTSTRAP_VERSION}/" {} \;
sed -i 's/\(^.*flag.String(\"bootstrap-version\",\) *\"[^\"]\+\"/\1 \"${BOOTSTRAP_VERSION}\"/' test.go
Expand Down
2 changes: 1 addition & 1 deletion build.env
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
source ./tools/shell_functions.inc

go version >/dev/null 2>&1 || fail "Go is not installed or is not in \$PATH. See https://vitess.io/contributing/build-from-source for install instructions."
goversion_min 1.25.9 || echo "Go version reported: `go version`. Version 1.25.9+ recommended. See https://vitess.io/contributing/build-from-source for install instructions."
goversion_min 1.25.10 || echo "Go version reported: `go version`. Version 1.25.10+ recommended. See https://vitess.io/contributing/build-from-source for install instructions."

mkdir -p dist
mkdir -p bin
Expand Down
6 changes: 5 additions & 1 deletion docker/bootstrap/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -206,4 +206,8 @@ List of changes between bootstrap image versions.

## [48.3] - 2026-04-09
### Changes
- Update build to golang 1.25.9
- Update build to golang 1.25.9

## [48.4] - 2026-05-08
### Changes
- Update build to golang 1.25.10
2 changes: 1 addition & 1 deletion docker/bootstrap/Dockerfile.common
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
FROM --platform=linux/amd64 golang:1.25.9-bookworm@sha256:e29e14633a7d43fe3161fee1849a0a11efe81145b0572bfc162743698c3257ae
FROM --platform=linux/amd64 golang:1.25.10-bookworm@sha256:6e77087079b02aa8079cd7723da7cb4563703226ed54c6f6be7765050cd884d5

Check warning on line 1 in docker/bootstrap/Dockerfile.common

View workflow job for this annotation

GitHub Actions / Region Sharding example using etcd on Ubuntu

FROM --platform flag should not use a constant value

FromPlatformFlagConstDisallowed: FROM --platform flag should not use constant value "linux/amd64" More info: https://docs.docker.com/go/dockerfile/rule/from-platform-flag-const-disallowed/

Check warning on line 1 in docker/bootstrap/Dockerfile.common

View workflow job for this annotation

GitHub Actions / Local example using etcd on Ubuntu

FROM --platform flag should not use a constant value

FromPlatformFlagConstDisallowed: FROM --platform flag should not use constant value "linux/amd64" More info: https://docs.docker.com/go/dockerfile/rule/from-platform-flag-const-disallowed/

Check warning on line 1 in docker/bootstrap/Dockerfile.common

View workflow job for this annotation

GitHub Actions / Local example using zk2 on Ubuntu

FROM --platform flag should not use a constant value

FromPlatformFlagConstDisallowed: FROM --platform flag should not use constant value "linux/amd64" More info: https://docs.docker.com/go/dockerfile/rule/from-platform-flag-const-disallowed/

Check warning on line 1 in docker/bootstrap/Dockerfile.common

View workflow job for this annotation

GitHub Actions / Java Docker Test

FROM --platform flag should not use a constant value

FromPlatformFlagConstDisallowed: FROM --platform flag should not use constant value "linux/amd64" More info: https://docs.docker.com/go/dockerfile/rule/from-platform-flag-const-disallowed/

Check warning on line 1 in docker/bootstrap/Dockerfile.common

View workflow job for this annotation

GitHub Actions / Docker Test Cluster

FROM --platform flag should not use a constant value

FromPlatformFlagConstDisallowed: FROM --platform flag should not use constant value "linux/amd64" More info: https://docs.docker.com/go/dockerfile/rule/from-platform-flag-const-disallowed/

# Install Vitess build dependencies
RUN apt-get update && DEBIAN_FRONTEND=noninteractive apt-get install -y --no-install-recommends \

Check warning on line 4 in docker/bootstrap/Dockerfile.common

View workflow job for this annotation

GitHub Actions / Region Sharding example using etcd on Ubuntu

FROM --platform flag should not use a constant value

FromPlatformFlagConstDisallowed: FROM --platform flag should not use constant value "linux/amd64" More info: https://docs.docker.com/go/dockerfile/rule/from-platform-flag-const-disallowed/

Check warning on line 4 in docker/bootstrap/Dockerfile.common

View workflow job for this annotation

GitHub Actions / Region Sharding example using etcd on Ubuntu

Default value for global ARG results in an empty or invalid base image name

InvalidDefaultArgInFrom: Default value for ARG "${image}" results in empty or invalid base image name More info: https://docs.docker.com/go/dockerfile/rule/invalid-default-arg-in-from/

Check warning on line 4 in docker/bootstrap/Dockerfile.common

View workflow job for this annotation

GitHub Actions / Local example using etcd on Ubuntu

FROM --platform flag should not use a constant value

FromPlatformFlagConstDisallowed: FROM --platform flag should not use constant value "linux/amd64" More info: https://docs.docker.com/go/dockerfile/rule/from-platform-flag-const-disallowed/

Check warning on line 4 in docker/bootstrap/Dockerfile.common

View workflow job for this annotation

GitHub Actions / Local example using etcd on Ubuntu

Default value for global ARG results in an empty or invalid base image name

InvalidDefaultArgInFrom: Default value for ARG "${image}" results in empty or invalid base image name More info: https://docs.docker.com/go/dockerfile/rule/invalid-default-arg-in-from/

Check warning on line 4 in docker/bootstrap/Dockerfile.common

View workflow job for this annotation

GitHub Actions / Local example using zk2 on Ubuntu

FROM --platform flag should not use a constant value

FromPlatformFlagConstDisallowed: FROM --platform flag should not use constant value "linux/amd64" More info: https://docs.docker.com/go/dockerfile/rule/from-platform-flag-const-disallowed/

Check warning on line 4 in docker/bootstrap/Dockerfile.common

View workflow job for this annotation

GitHub Actions / Local example using zk2 on Ubuntu

Default value for global ARG results in an empty or invalid base image name

InvalidDefaultArgInFrom: Default value for ARG "${image}" results in empty or invalid base image name More info: https://docs.docker.com/go/dockerfile/rule/invalid-default-arg-in-from/

Check warning on line 4 in docker/bootstrap/Dockerfile.common

View workflow job for this annotation

GitHub Actions / Java Docker Test

FROM --platform flag should not use a constant value

FromPlatformFlagConstDisallowed: FROM --platform flag should not use constant value "linux/amd64" More info: https://docs.docker.com/go/dockerfile/rule/from-platform-flag-const-disallowed/

Check warning on line 4 in docker/bootstrap/Dockerfile.common

View workflow job for this annotation

GitHub Actions / Java Docker Test

Default value for global ARG results in an empty or invalid base image name

InvalidDefaultArgInFrom: Default value for ARG "${image}" results in empty or invalid base image name More info: https://docs.docker.com/go/dockerfile/rule/invalid-default-arg-in-from/

Check warning on line 4 in docker/bootstrap/Dockerfile.common

View workflow job for this annotation

GitHub Actions / Docker Test Cluster

Default value for global ARG results in an empty or invalid base image name

InvalidDefaultArgInFrom: Default value for ARG "${image}" results in empty or invalid base image name More info: https://docs.docker.com/go/dockerfile/rule/invalid-default-arg-in-from/

Check warning on line 4 in docker/bootstrap/Dockerfile.common

View workflow job for this annotation

GitHub Actions / Docker Test Cluster

FROM --platform flag should not use a constant value

FromPlatformFlagConstDisallowed: FROM --platform flag should not use constant value "linux/amd64" More info: https://docs.docker.com/go/dockerfile/rule/from-platform-flag-const-disallowed/
# TODO(mberlin): Group these to make it easier to understand which library actually requires them.
ant \
ca-certificates \
Expand All @@ -21,11 +21,11 @@
&& rm -rf /var/lib/apt/lists/*

# Set up Vitess environment (equivalent to '. dev.env')
ENV VTROOT /vt/src/vitess.io/vitess

Check warning on line 24 in docker/bootstrap/Dockerfile.common

View workflow job for this annotation

GitHub Actions / Region Sharding example using etcd on Ubuntu

Legacy key/value format with whitespace separator should not be used

LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format More info: https://docs.docker.com/go/dockerfile/rule/legacy-key-value-format/

Check warning on line 24 in docker/bootstrap/Dockerfile.common

View workflow job for this annotation

GitHub Actions / Local example using etcd on Ubuntu

Legacy key/value format with whitespace separator should not be used

LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format More info: https://docs.docker.com/go/dockerfile/rule/legacy-key-value-format/

Check warning on line 24 in docker/bootstrap/Dockerfile.common

View workflow job for this annotation

GitHub Actions / Local example using zk2 on Ubuntu

Legacy key/value format with whitespace separator should not be used

LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format More info: https://docs.docker.com/go/dockerfile/rule/legacy-key-value-format/

Check warning on line 24 in docker/bootstrap/Dockerfile.common

View workflow job for this annotation

GitHub Actions / Java Docker Test

Legacy key/value format with whitespace separator should not be used

LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format More info: https://docs.docker.com/go/dockerfile/rule/legacy-key-value-format/

Check warning on line 24 in docker/bootstrap/Dockerfile.common

View workflow job for this annotation

GitHub Actions / Docker Test Cluster

Legacy key/value format with whitespace separator should not be used

LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format More info: https://docs.docker.com/go/dockerfile/rule/legacy-key-value-format/
ENV VTDATAROOT /vt/vtdataroot

Check warning on line 25 in docker/bootstrap/Dockerfile.common

View workflow job for this annotation

GitHub Actions / Region Sharding example using etcd on Ubuntu

Legacy key/value format with whitespace separator should not be used

LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format More info: https://docs.docker.com/go/dockerfile/rule/legacy-key-value-format/

Check warning on line 25 in docker/bootstrap/Dockerfile.common

View workflow job for this annotation

GitHub Actions / Local example using etcd on Ubuntu

Legacy key/value format with whitespace separator should not be used

LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format More info: https://docs.docker.com/go/dockerfile/rule/legacy-key-value-format/

Check warning on line 25 in docker/bootstrap/Dockerfile.common

View workflow job for this annotation

GitHub Actions / Local example using zk2 on Ubuntu

Legacy key/value format with whitespace separator should not be used

LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format More info: https://docs.docker.com/go/dockerfile/rule/legacy-key-value-format/

Check warning on line 25 in docker/bootstrap/Dockerfile.common

View workflow job for this annotation

GitHub Actions / Java Docker Test

Legacy key/value format with whitespace separator should not be used

LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format More info: https://docs.docker.com/go/dockerfile/rule/legacy-key-value-format/

Check warning on line 25 in docker/bootstrap/Dockerfile.common

View workflow job for this annotation

GitHub Actions / Docker Test Cluster

Legacy key/value format with whitespace separator should not be used

LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format More info: https://docs.docker.com/go/dockerfile/rule/legacy-key-value-format/
ENV VTPORTSTART 15000

Check warning on line 26 in docker/bootstrap/Dockerfile.common

View workflow job for this annotation

GitHub Actions / Region Sharding example using etcd on Ubuntu

Legacy key/value format with whitespace separator should not be used

LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format More info: https://docs.docker.com/go/dockerfile/rule/legacy-key-value-format/

Check warning on line 26 in docker/bootstrap/Dockerfile.common

View workflow job for this annotation

GitHub Actions / Local example using etcd on Ubuntu

Legacy key/value format with whitespace separator should not be used

LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format More info: https://docs.docker.com/go/dockerfile/rule/legacy-key-value-format/

Check warning on line 26 in docker/bootstrap/Dockerfile.common

View workflow job for this annotation

GitHub Actions / Local example using zk2 on Ubuntu

Legacy key/value format with whitespace separator should not be used

LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format More info: https://docs.docker.com/go/dockerfile/rule/legacy-key-value-format/

Check warning on line 26 in docker/bootstrap/Dockerfile.common

View workflow job for this annotation

GitHub Actions / Java Docker Test

Legacy key/value format with whitespace separator should not be used

LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format More info: https://docs.docker.com/go/dockerfile/rule/legacy-key-value-format/

Check warning on line 26 in docker/bootstrap/Dockerfile.common

View workflow job for this annotation

GitHub Actions / Docker Test Cluster

Legacy key/value format with whitespace separator should not be used

LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format More info: https://docs.docker.com/go/dockerfile/rule/legacy-key-value-format/
ENV PATH $VTROOT/bin:$VTROOT/dist/maven/bin:$PATH

Check warning on line 27 in docker/bootstrap/Dockerfile.common

View workflow job for this annotation

GitHub Actions / Region Sharding example using etcd on Ubuntu

Legacy key/value format with whitespace separator should not be used

LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format More info: https://docs.docker.com/go/dockerfile/rule/legacy-key-value-format/

Check warning on line 27 in docker/bootstrap/Dockerfile.common

View workflow job for this annotation

GitHub Actions / Local example using etcd on Ubuntu

Legacy key/value format with whitespace separator should not be used

LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format More info: https://docs.docker.com/go/dockerfile/rule/legacy-key-value-format/

Check warning on line 27 in docker/bootstrap/Dockerfile.common

View workflow job for this annotation

GitHub Actions / Local example using zk2 on Ubuntu

Legacy key/value format with whitespace separator should not be used

LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format More info: https://docs.docker.com/go/dockerfile/rule/legacy-key-value-format/

Check warning on line 27 in docker/bootstrap/Dockerfile.common

View workflow job for this annotation

GitHub Actions / Java Docker Test

Legacy key/value format with whitespace separator should not be used

LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format More info: https://docs.docker.com/go/dockerfile/rule/legacy-key-value-format/

Check warning on line 27 in docker/bootstrap/Dockerfile.common

View workflow job for this annotation

GitHub Actions / Docker Test Cluster

Legacy key/value format with whitespace separator should not be used

LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format More info: https://docs.docker.com/go/dockerfile/rule/legacy-key-value-format/
ENV USER vitess

Check warning on line 28 in docker/bootstrap/Dockerfile.common

View workflow job for this annotation

GitHub Actions / Region Sharding example using etcd on Ubuntu

Legacy key/value format with whitespace separator should not be used

LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format More info: https://docs.docker.com/go/dockerfile/rule/legacy-key-value-format/

Check warning on line 28 in docker/bootstrap/Dockerfile.common

View workflow job for this annotation

GitHub Actions / Local example using etcd on Ubuntu

Legacy key/value format with whitespace separator should not be used

LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format More info: https://docs.docker.com/go/dockerfile/rule/legacy-key-value-format/

Check warning on line 28 in docker/bootstrap/Dockerfile.common

View workflow job for this annotation

GitHub Actions / Local example using zk2 on Ubuntu

Legacy key/value format with whitespace separator should not be used

LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format More info: https://docs.docker.com/go/dockerfile/rule/legacy-key-value-format/

Check warning on line 28 in docker/bootstrap/Dockerfile.common

View workflow job for this annotation

GitHub Actions / Java Docker Test

Legacy key/value format with whitespace separator should not be used

LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format More info: https://docs.docker.com/go/dockerfile/rule/legacy-key-value-format/

Check warning on line 28 in docker/bootstrap/Dockerfile.common

View workflow job for this annotation

GitHub Actions / Docker Test Cluster

Legacy key/value format with whitespace separator should not be used

LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format More info: https://docs.docker.com/go/dockerfile/rule/legacy-key-value-format/

# Copy files needed for bootstrap
COPY bootstrap.sh dev.env build.env go.mod go.sum /vt/src/vitess.io/vitess/
Expand Down
2 changes: 1 addition & 1 deletion docker/lite/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
# See the License for the specific language governing permissions and
# limitations under the License.

FROM --platform=linux/amd64 golang:1.25.9-bookworm@sha256:e29e14633a7d43fe3161fee1849a0a11efe81145b0572bfc162743698c3257ae AS builder
FROM --platform=linux/amd64 golang:1.25.10-bookworm@sha256:6e77087079b02aa8079cd7723da7cb4563703226ed54c6f6be7765050cd884d5 AS builder

Check warning on line 15 in docker/lite/Dockerfile

View workflow job for this annotation

GitHub Actions / Build docker/lite/Dockerfile

FROM --platform flag should not use a constant value

FromPlatformFlagConstDisallowed: FROM --platform flag should not use constant value "linux/amd64" More info: https://docs.docker.com/go/dockerfile/rule/from-platform-flag-const-disallowed/

# Allows docker builds to set the BUILD_NUMBER
ARG BUILD_NUMBER
Expand Down Expand Up @@ -40,7 +40,7 @@
RUN make install PREFIX=/vt/install

# Start over and build the final image.
FROM --platform=linux/amd64 debian:bookworm-slim@sha256:09c53e50b5110eb26e0932ab77934481ce9c0068069d4f28e3e7493e51323bfe

Check warning on line 43 in docker/lite/Dockerfile

View workflow job for this annotation

GitHub Actions / Build docker/lite/Dockerfile

FROM --platform flag should not use a constant value

FromPlatformFlagConstDisallowed: FROM --platform flag should not use constant value "linux/amd64" More info: https://docs.docker.com/go/dockerfile/rule/from-platform-flag-const-disallowed/

# Install locale required for mysqlsh
RUN apt-get update && apt-get install -y locales \
Expand All @@ -56,9 +56,9 @@
RUN mkdir -p /vt/vtdataroot /home/vitess && chown -R vitess:vitess /vt /home/vitess

# Set up Vitess environment (just enough to run pre-built Go binaries)
ENV VTROOT /vt

Check warning on line 59 in docker/lite/Dockerfile

View workflow job for this annotation

GitHub Actions / Build docker/lite/Dockerfile

Legacy key/value format with whitespace separator should not be used

LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format More info: https://docs.docker.com/go/dockerfile/rule/legacy-key-value-format/
ENV VTDATAROOT /vt/vtdataroot

Check warning on line 60 in docker/lite/Dockerfile

View workflow job for this annotation

GitHub Actions / Build docker/lite/Dockerfile

Legacy key/value format with whitespace separator should not be used

LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format More info: https://docs.docker.com/go/dockerfile/rule/legacy-key-value-format/
ENV PATH $VTROOT/bin:$PATH

Check warning on line 61 in docker/lite/Dockerfile

View workflow job for this annotation

GitHub Actions / Build docker/lite/Dockerfile

Legacy key/value format with whitespace separator should not be used

LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format More info: https://docs.docker.com/go/dockerfile/rule/legacy-key-value-format/

# Copy artifacts from builder layer.
COPY --from=builder /etc/ssl/certs/ca-certificates.crt /etc/ssl/certs/ca-certificates.crt
Expand Down
2 changes: 1 addition & 1 deletion docker/lite/Dockerfile.mysql80
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
# See the License for the specific language governing permissions and
# limitations under the License.

FROM --platform=linux/amd64 golang:1.25.9-bookworm@sha256:e29e14633a7d43fe3161fee1849a0a11efe81145b0572bfc162743698c3257ae AS builder
FROM --platform=linux/amd64 golang:1.25.10-bookworm@sha256:6e77087079b02aa8079cd7723da7cb4563703226ed54c6f6be7765050cd884d5 AS builder

Check warning on line 15 in docker/lite/Dockerfile.mysql80

View workflow job for this annotation

GitHub Actions / Build docker/lite/Dockerfile.mysql80

FROM --platform flag should not use a constant value

FromPlatformFlagConstDisallowed: FROM --platform flag should not use constant value "linux/amd64" More info: https://docs.docker.com/go/dockerfile/rule/from-platform-flag-const-disallowed/

# Allows docker builds to set the BUILD_NUMBER
ARG BUILD_NUMBER
Expand Down Expand Up @@ -40,7 +40,7 @@
RUN make install PREFIX=/vt/install

# Start over and build the final image.
FROM --platform=linux/amd64 debian:bookworm-slim@sha256:09c53e50b5110eb26e0932ab77934481ce9c0068069d4f28e3e7493e51323bfe

Check warning on line 43 in docker/lite/Dockerfile.mysql80

View workflow job for this annotation

GitHub Actions / Build docker/lite/Dockerfile.mysql80

FROM --platform flag should not use a constant value

FromPlatformFlagConstDisallowed: FROM --platform flag should not use constant value "linux/amd64" More info: https://docs.docker.com/go/dockerfile/rule/from-platform-flag-const-disallowed/

# Install locale required for mysqlsh
RUN apt-get update && apt-get install -y locales \
Expand All @@ -56,9 +56,9 @@
RUN mkdir -p /vt/vtdataroot /home/vitess && chown -R vitess:vitess /vt /home/vitess

# Set up Vitess environment (just enough to run pre-built Go binaries)
ENV VTROOT /vt

Check warning on line 59 in docker/lite/Dockerfile.mysql80

View workflow job for this annotation

GitHub Actions / Build docker/lite/Dockerfile.mysql80

Legacy key/value format with whitespace separator should not be used

LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format More info: https://docs.docker.com/go/dockerfile/rule/legacy-key-value-format/
ENV VTDATAROOT /vt/vtdataroot

Check warning on line 60 in docker/lite/Dockerfile.mysql80

View workflow job for this annotation

GitHub Actions / Build docker/lite/Dockerfile.mysql80

Legacy key/value format with whitespace separator should not be used

LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format More info: https://docs.docker.com/go/dockerfile/rule/legacy-key-value-format/
ENV PATH $VTROOT/bin:$PATH

Check warning on line 61 in docker/lite/Dockerfile.mysql80

View workflow job for this annotation

GitHub Actions / Build docker/lite/Dockerfile.mysql80

Legacy key/value format with whitespace separator should not be used

LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format More info: https://docs.docker.com/go/dockerfile/rule/legacy-key-value-format/

# Copy artifacts from builder layer.
COPY --from=builder /etc/ssl/certs/ca-certificates.crt /etc/ssl/certs/ca-certificates.crt
Expand Down
2 changes: 1 addition & 1 deletion docker/lite/Dockerfile.mysql84
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
# See the License for the specific language governing permissions and
# limitations under the License.

FROM --platform=linux/amd64 golang:1.25.9-bookworm@sha256:e29e14633a7d43fe3161fee1849a0a11efe81145b0572bfc162743698c3257ae AS builder
FROM --platform=linux/amd64 golang:1.25.10-bookworm@sha256:6e77087079b02aa8079cd7723da7cb4563703226ed54c6f6be7765050cd884d5 AS builder

Check warning on line 15 in docker/lite/Dockerfile.mysql84

View workflow job for this annotation

GitHub Actions / Build docker/lite/Dockerfile.mysql84

FROM --platform flag should not use a constant value

FromPlatformFlagConstDisallowed: FROM --platform flag should not use constant value "linux/amd64" More info: https://docs.docker.com/go/dockerfile/rule/from-platform-flag-const-disallowed/

# Allows docker builds to set the BUILD_NUMBER
ARG BUILD_NUMBER
Expand Down Expand Up @@ -40,7 +40,7 @@
RUN make install PREFIX=/vt/install

# Start over and build the final image.
FROM --platform=linux/amd64 debian:bookworm-slim@sha256:09c53e50b5110eb26e0932ab77934481ce9c0068069d4f28e3e7493e51323bfe

Check warning on line 43 in docker/lite/Dockerfile.mysql84

View workflow job for this annotation

GitHub Actions / Build docker/lite/Dockerfile.mysql84

FROM --platform flag should not use a constant value

FromPlatformFlagConstDisallowed: FROM --platform flag should not use constant value "linux/amd64" More info: https://docs.docker.com/go/dockerfile/rule/from-platform-flag-const-disallowed/

# Install locale required for mysqlsh
RUN apt-get update && apt-get install -y locales \
Expand All @@ -56,9 +56,9 @@
RUN mkdir -p /vt/vtdataroot /home/vitess && chown -R vitess:vitess /vt /home/vitess

# Set up Vitess environment (just enough to run pre-built Go binaries)
ENV VTROOT /vt

Check warning on line 59 in docker/lite/Dockerfile.mysql84

View workflow job for this annotation

GitHub Actions / Build docker/lite/Dockerfile.mysql84

Legacy key/value format with whitespace separator should not be used

LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format More info: https://docs.docker.com/go/dockerfile/rule/legacy-key-value-format/
ENV VTDATAROOT /vt/vtdataroot

Check warning on line 60 in docker/lite/Dockerfile.mysql84

View workflow job for this annotation

GitHub Actions / Build docker/lite/Dockerfile.mysql84

Legacy key/value format with whitespace separator should not be used

LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format More info: https://docs.docker.com/go/dockerfile/rule/legacy-key-value-format/
ENV PATH $VTROOT/bin:$PATH

Check warning on line 61 in docker/lite/Dockerfile.mysql84

View workflow job for this annotation

GitHub Actions / Build docker/lite/Dockerfile.mysql84

Legacy key/value format with whitespace separator should not be used

LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format More info: https://docs.docker.com/go/dockerfile/rule/legacy-key-value-format/

# Copy artifacts from builder layer.
COPY --from=builder /etc/ssl/certs/ca-certificates.crt /etc/ssl/certs/ca-certificates.crt
Expand Down
2 changes: 1 addition & 1 deletion docker/lite/Dockerfile.percona80
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
# See the License for the specific language governing permissions and
# limitations under the License.

FROM --platform=linux/amd64 golang:1.25.9-bookworm@sha256:e29e14633a7d43fe3161fee1849a0a11efe81145b0572bfc162743698c3257ae AS builder
FROM --platform=linux/amd64 golang:1.25.10-bookworm@sha256:6e77087079b02aa8079cd7723da7cb4563703226ed54c6f6be7765050cd884d5 AS builder

Check warning on line 15 in docker/lite/Dockerfile.percona80

View workflow job for this annotation

GitHub Actions / Build docker/lite/Dockerfile.percona80

FROM --platform flag should not use a constant value

FromPlatformFlagConstDisallowed: FROM --platform flag should not use constant value "linux/amd64" More info: https://docs.docker.com/go/dockerfile/rule/from-platform-flag-const-disallowed/

# Allows docker builds to set the BUILD_NUMBER
ARG BUILD_NUMBER
Expand Down Expand Up @@ -40,7 +40,7 @@
RUN make install PREFIX=/vt/install

# Start over and build the final image.
FROM --platform=linux/amd64 debian:bookworm-slim@sha256:09c53e50b5110eb26e0932ab77934481ce9c0068069d4f28e3e7493e51323bfe

Check warning on line 43 in docker/lite/Dockerfile.percona80

View workflow job for this annotation

GitHub Actions / Build docker/lite/Dockerfile.percona80

FROM --platform flag should not use a constant value

FromPlatformFlagConstDisallowed: FROM --platform flag should not use constant value "linux/amd64" More info: https://docs.docker.com/go/dockerfile/rule/from-platform-flag-const-disallowed/

# Install dependencies
COPY docker/utils/install_dependencies.sh /vt/dist/install_dependencies.sh
Expand All @@ -51,9 +51,9 @@
RUN mkdir -p /vt/vtdataroot && chown -R vitess:vitess /vt

# Set up Vitess environment (just enough to run pre-built Go binaries)
ENV VTROOT /vt

Check warning on line 54 in docker/lite/Dockerfile.percona80

View workflow job for this annotation

GitHub Actions / Build docker/lite/Dockerfile.percona80

Legacy key/value format with whitespace separator should not be used

LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format More info: https://docs.docker.com/go/dockerfile/rule/legacy-key-value-format/
ENV VTDATAROOT /vt/vtdataroot

Check warning on line 55 in docker/lite/Dockerfile.percona80

View workflow job for this annotation

GitHub Actions / Build docker/lite/Dockerfile.percona80

Legacy key/value format with whitespace separator should not be used

LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format More info: https://docs.docker.com/go/dockerfile/rule/legacy-key-value-format/
ENV PATH $VTROOT/bin:$PATH

Check warning on line 56 in docker/lite/Dockerfile.percona80

View workflow job for this annotation

GitHub Actions / Build docker/lite/Dockerfile.percona80

Legacy key/value format with whitespace separator should not be used

LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format More info: https://docs.docker.com/go/dockerfile/rule/legacy-key-value-format/

# Copy artifacts from builder layer.
COPY --from=builder --chown=vitess:vitess /vt/install /vt
Expand Down
2 changes: 1 addition & 1 deletion docker/vttestserver/Dockerfile.mysql80
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
# See the License for the specific language governing permissions and
# limitations under the License.

FROM --platform=linux/amd64 golang:1.25.9-bookworm@sha256:e29e14633a7d43fe3161fee1849a0a11efe81145b0572bfc162743698c3257ae AS builder
FROM --platform=linux/amd64 golang:1.25.10-bookworm@sha256:6e77087079b02aa8079cd7723da7cb4563703226ed54c6f6be7765050cd884d5 AS builder

# Allows docker builds to set the BUILD_NUMBER
ARG BUILD_NUMBER
Expand Down
2 changes: 1 addition & 1 deletion docker/vttestserver/Dockerfile.mysql84
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
# See the License for the specific language governing permissions and
# limitations under the License.

FROM --platform=linux/amd64 golang:1.25.9-bookworm@sha256:e29e14633a7d43fe3161fee1849a0a11efe81145b0572bfc162743698c3257ae AS builder
FROM --platform=linux/amd64 golang:1.25.10-bookworm@sha256:6e77087079b02aa8079cd7723da7cb4563703226ed54c6f6be7765050cd884d5 AS builder

# Allows docker builds to set the BUILD_NUMBER
ARG BUILD_NUMBER
Expand Down
2 changes: 1 addition & 1 deletion go.mod
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module vitess.io/vitess

go 1.25.9
go 1.25.10

tool gotest.tools/gotestsum

Expand Down
2 changes: 1 addition & 1 deletion test.go
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ For example:
// Flags
var (
flavor = flag.String("flavor", "mysql80", "comma-separated bootstrap flavor(s) to run against (when using Docker mode). Available flavors: all,"+flavors)
bootstrapVersion = flag.String("bootstrap-version", "48.3", "the version identifier to use for the docker images")
bootstrapVersion = flag.String("bootstrap-version", "48.4", "the version identifier to use for the docker images")
runCount = flag.Int("runs", 1, "run each test this many times")
logPass = flag.Bool("log-pass", false, "log test output even if it passes")
timeout = flag.Duration("timeout", 30*time.Minute, "timeout for each test")
Expand Down
Loading