Skip to content

[release-23.0] Upgrade the Golang version to go1.25.10#20064

Merged
timvaillancourt merged 2 commits into
release-23.0from
upgrade-go-to-1.25.10-on-release-23.0
May 8, 2026
Merged

[release-23.0] Upgrade the Golang version to go1.25.10#20064
timvaillancourt merged 2 commits into
release-23.0from
upgrade-go-to-1.25.10-on-release-23.0

Conversation

@vitess-bot
Copy link
Copy Markdown
Contributor

This Pull Request bumps the Golang version to go1.25.10 and the bootstrap version to 48.4.

Do not trust the bot blindly. A thorough code review must be done to ensure all the files have been correctly modified.

cc @vitessio/release

Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Copilot AI review requested due to automatic review settings May 8, 2026 01:03
@vitess-bot vitess-bot added Benchmark me Add label to PR to run benchmarks Component: General Changes throughout the code base go Type: CI/Build labels May 8, 2026
@vitess-bot vitess-bot requested a review from a team May 8, 2026 01:03
@vitess-bot
Copy link
Copy Markdown
Contributor

vitess-bot Bot commented May 8, 2026

Hello! 👋

This Pull Request is now handled by arewefastyet. The current HEAD and future commits will be benchmarked.

You can find the performance comparison on the arewefastyet website.

@github-actions github-actions Bot added this to the v23.0.5 milestone May 8, 2026
@vitess-bot vitess-bot Bot added the NeedsWebsiteDocsUpdate What it says label May 8, 2026
@vitess-bot vitess-bot Bot added NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels May 8, 2026
@vitess-bot
Copy link
Copy Markdown
Contributor

vitess-bot Bot commented May 8, 2026

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the Vitess release-23.0 branch build/tooling to use Go 1.25.10 and aligns the Docker bootstrap image versioning to 48.4.

Changes:

  • Bump the Go version from 1.25.9 to 1.25.10 in module/build tooling.
  • Update bootstrap image version from 48.3 to 48.4 across Makefile + test harness.
  • Refresh Docker build base images to golang:1.25.10-bookworm (pinned by digest) and record the change in the bootstrap changelog.

Reviewed changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated no comments.

Show a summary per file
File Description
test.go Updates default -bootstrap-version flag value to 48.4.
Makefile Bumps BOOTSTRAP_VERSION to 48.4 for bootstrap build/push/test targets.
go.mod Updates the go directive to 1.25.10.
docker/vttestserver/Dockerfile.mysql84 Updates builder base image to Go 1.25.10 pinned digest.
docker/vttestserver/Dockerfile.mysql80 Updates builder base image to Go 1.25.10 pinned digest.
docker/lite/Dockerfile.percona80 Updates builder base image to Go 1.25.10 pinned digest.
docker/lite/Dockerfile.mysql84 Updates builder base image to Go 1.25.10 pinned digest.
docker/lite/Dockerfile.mysql80 Updates builder base image to Go 1.25.10 pinned digest.
docker/lite/Dockerfile Updates builder base image to Go 1.25.10 pinned digest.
docker/bootstrap/Dockerfile.common Updates bootstrap base image to Go 1.25.10 pinned digest.
docker/bootstrap/CHANGELOG.md Adds bootstrap image version 48.4 entry for the Go bump.
build.env Updates the recommended minimum Go version check to 1.25.10.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Signed-off-by: Matt Lord <mattalord@gmail.com>
@timvaillancourt timvaillancourt enabled auto-merge (squash) May 8, 2026 14:46
@timvaillancourt timvaillancourt removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says labels May 8, 2026
@timvaillancourt timvaillancourt removed NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels May 8, 2026
@timvaillancourt timvaillancourt merged commit 17af84e into release-23.0 May 8, 2026
108 of 113 checks passed
@timvaillancourt timvaillancourt deleted the upgrade-go-to-1.25.10-on-release-23.0 branch May 8, 2026 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Benchmark me Add label to PR to run benchmarks Component: Build/CI Component: Docker Component: General Changes throughout the code base go Type: CI/Build Type: Dependencies Dependency updates

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants