Skip to content

Fix: Move useOptimistic to provider level for consistent cart state #1469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix: Move useOptimistic to provider level for consistent cart state #1469

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 13 additions & 11 deletions components/cart/cart-context.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,8 @@ type CartAction =

type CartContextType = {
cartPromise: Promise<Cart | undefined>;
optimisticCart: Cart | undefined;
updateOptimisticCart: (action: CartAction) => void;
};

const CartContext = createContext<CartContextType | undefined>(undefined);
Expand Down Expand Up @@ -197,8 +199,14 @@ export function CartProvider({
children: React.ReactNode;
cartPromise: Promise<Cart | undefined>;
}) {
const initialCart = use(cartPromise);
const [optimisticCart, updateOptimisticCart] = useOptimistic(
initialCart,
cartReducer
);

return (
<CartContext.Provider value={{ cartPromise }}>
<CartContext.Provider value={{ cartPromise, optimisticCart, updateOptimisticCart }}>
{children}
</CartContext.Provider>
);
Expand All @@ -210,29 +218,23 @@ export function useCart() {
throw new Error('useCart must be used within a CartProvider');
}

const initialCart = use(context.cartPromise);
const [optimisticCart, updateOptimisticCart] = useOptimistic(
initialCart,
cartReducer
);

const updateCartItem = (merchandiseId: string, updateType: UpdateType) => {
updateOptimisticCart({
context.updateOptimisticCart({
type: 'UPDATE_ITEM',
payload: { merchandiseId, updateType }
});
};

const addCartItem = (variant: ProductVariant, product: Product) => {
updateOptimisticCart({ type: 'ADD_ITEM', payload: { variant, product } });
context.updateOptimisticCart({ type: 'ADD_ITEM', payload: { variant, product } });
};

return useMemo(
() => ({
cart: optimisticCart,
cart: context.optimisticCart,
updateCartItem,
addCartItem
}),
[optimisticCart]
[context.optimisticCart, context.updateOptimisticCart]
);
}