Fix: Move useOptimistic to provider level for consistent cart state #1469
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: Move useOptimistic to provider level for consistent cart state
Background:
Discovered a bug where there was noticeable lag between adding products to cart and seeing the cart update. Initially confusing because
useOptimistic
was being used throughout the codebase, but the issue was that eachuseCart()
hook call was creating its own optimistic cart instance.Problem:
Cart updates had lag because
useOptimistic
was being created in eachuseCart()
hook call, resulting in multiple optimistic cart instances. Components using the cart outside of the hook were seeing the actual cart (with server delay) while hook consumers saw the optimistic cart, causing inconsistent UI updates.Solution:
Moved
useOptimistic
from theuseCart
hook to theCartProvider
component, creating a single shared optimistic cart instance that all components can access through the context.Result:
All cart operations now update instantly across the entire application, eliminating the lag between adding items and seeing them in the cart UI.
Files changed:
components/cart/cart-context.tsx