Skip to content

prompt for a password always if --storepass option #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

prompt for a password always if --storepass option #6

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
366e0c6
prompt for a password always if `--storepass` option
upenn-hughmac Aug 30, 2024
002f7d1
update --storepass option help text to reflect intended behavior
Jul 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions shib/cli.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,8 +142,11 @@ def main():
' Defaults to 1 hour / {0} seconds, min {1} max 12 hours / {2} '
'seconds.'.format(str(60*60),str(60*15),str(60*60*12)))
parser.add_argument('--storepass',
help='Store the password to the system keyring service and retrieve on following requests'
' If unset you will be prompted for password on every request',
help='Store the password to the system keyring service to allow for automatic retrieval'
' on following requests. If set, you will be prompted for a password that will then'
' be stored in the system keyring service. If unset, the script will attempt to retrieve'
' a previously stored password from the system keyring service and then prompt you for'
' a password if there is not a stored password.',
action='store_true')
parser.add_argument('--user',
help='Login as this user'
Expand Down Expand Up @@ -259,7 +262,7 @@ def main():
password = None
password_stored = False

if keyring is not None:
if keyring is not None and not args.storepass:
try:
password = keyring.get_password("aws-federated-auth", "password")
except Exception:
Expand Down