prompt for a password always if --storepass option
#6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rchu4
requested changes
Jul 23, 2025
There was a problem hiding this comment.
I suggest updating the --storepass help description in lines 145-6 to reflect the true behavior of --storepass. Suggestion:
Store the password to the system keyring service to allow for automatic retrieval on following requests. If set, you will be prompted for a password that will then be stored in the system keyring service. If unset, the script will attempt to retrieve a previously stored password from the system keyring service and then prompt you for a password if there is not a stored password.
|
@rchu4, I concur! Would you commit that to this feature, please? Let's get you some credit for the verbiage! |
|
Ok, verbiage updated! |
rchu4
approved these changes
Jul 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per issue #5 , prompt for password always if
--storepassis used.