Media: Fix files not deleted from disk when recycle bin protection is enabled

[AndyButland]

Description

Protection for media in the recycle bin was introduced as a configurable option in #20378. In internal testing, a bug has been found where media files were not deleted from disk when emptying the recycle bin when protection was enabled by configuring Umbraco:Cms:Content:EnableMediaRecycleBinProtection to be true.

With this protection on, when media is trashed, files are renamed with a .deleted suffix (e.g., image.jpg → image.deleted.jpg), whilst property values still store the original paths

When deleting from the recycle bin, the code was trying to delete the original paths that no longer exist on disk, leaving orphaned .deleted files

Change Summary

• Added DeleteContainedFilesWithProtection method to RecycleBinMediaProtectionHelper that handles both:
  • Trashed media (files with .deleted suffix on disk).
  • Non-trashed media (force-deleted programmatically bypassing the recycle bin).
• Updated the file upload and image cropper notification handlers to use the helper for deleting the contained files when triggered and when protection is enabled:
  • FileUploadContentDeletedNotificationHandler.Handle(MediaDeletedNotification)
  • ImageCropperPropertyEditor.Handle(MediaDeletedNotification)

Testing

I've added unit tests for the newly introduced helper method RecycleBinMediaProtectionHelper.DeleteContainedFilesWithProtection.

For manual testing:

• Enable media file protection by configuring Umbraco:Cms:Content:EnableMediaRecycleBinProtection to be true.
• Delete a media file to the recycle bin.
• Note that the file on disk exists still with a .deleted suffix.
• Empty the recycle bin.
• Confirm the media file is deleted from disk,

[Copilot]

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.

[andr317c]

PR Tests good, The media items are now being deleted from disk after I remove the items from the Recycle Bin.

I have a question about the links for the media items in the recycle bin, the urls in the Links overview are missing the '.deleted' suffix. which means it points the old media path before it was moved. Should the link be updated to match the actual link when it is in the recycle bin?

Media item in recycle bin:

[AndyButland]

@andr317c - we should resolve that, yes - good catch. I've pushed a commit that will fix this.

[andr317c]

Looks good and tests good!