Fix login validation messages not showing on submit#21306
Fix login validation messages not showing on submit#21306andr317c merged 2 commits intoumbraco:mainfrom
Conversation
|
Hi there @calm329, thank you for this contribution! 👍 While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:
Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution. If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request. Thanks, from your friendly Umbraco GitHub bot 🤖 🙂 |
andr317c
left a comment
There was a problem hiding this comment.
LGTM! Thanks for contributing 😄
|
Thanks for your review & merge! I'd love to contribute more if possible! |
Co-authored-by: Andreas Zerbst <[email protected]> (cherry picked from commit 4df4ee9)
|
Cherry picked for 17.1 🎉 |
Updated [Umbraco.Cms.Persistence.Sqlite](https://github.com/umbraco/Umbraco-CMS) from 17.0.2 to 17.1.0. <details> <summary>Release notes</summary> _Sourced from [Umbraco.Cms.Persistence.Sqlite's releases](https://github.com/umbraco/Umbraco-CMS/releases)._ ## 17.1.0 # What's Changed Since 17.1.0-rc ### 🐛 Bug Fixes * Media: Fix files not deleted from disk when recycle bin protection is enabled by @AndyButland in umbraco/Umbraco-CMS#21309 * Document Editing: Refactor of Fix property variation change breaking document save via Infinite Editing (closes #21195) by @nielslyngsoe in umbraco/Umbraco-CMS#21293 * umbraco/Umbraco-CMS#21306 by @calm329 in umbraco/Umbraco-CMS#21306 **Full Changelog**: umbraco/Umbraco-CMS@release-17.1.0-rc...release-17.1.0 ## What's Changed Since the Last Release (17.0.2) ### 📦 Dependencies * Dependencies: Fixed dependency conflicts when installing Microsoft.EntityFrameworkCore.Design (closes #20421) by @lauraneto in umbraco/Umbraco-CMS#20474 * Dependencies: Remove `Microsoft.CodeAnalysis.CSharp` dependency from Umbraco.Infrastructure by @lauraneto in umbraco/Umbraco-CMS#20481 * build(deps): bumps @umbraco-ui/uui from 1.16.0-rc.0 to 1.16.0 by @iOvergaard in umbraco/Umbraco-CMS#20535 * Bump vite from 7.1.9 to 7.1.11 in /src/Umbraco.Web.UI.Client by @dependabot[bot] in umbraco/Umbraco-CMS#20580 * Bump vite from 7.1.9 to 7.1.11 in /src/Umbraco.Web.UI.Login by @dependabot[bot] in umbraco/Umbraco-CMS#20621 * Bump playwright and @playwright/test in /tests/Umbraco.Tests.AcceptanceTest by @dependabot[bot] in umbraco/Umbraco-CMS#20579 * Bump the npm_and_yarn group across 2 directories with 1 update by @dependabot[bot] in umbraco/Umbraco-CMS#20863 * Dependencies: Updates some dependencies to latest minor or patch releases by @AndyButland in umbraco/Umbraco-CMS#20953 * build(deps): bumps monaco-editor from 0.54.0 to 0.55.1 by @iOvergaard in umbraco/Umbraco-CMS#21054 ### 🌈 Accessibility Improvements * Entity Actions: Create button discernible text (fixes #20205) by @OskarKruger in umbraco/Umbraco-CMS#20434 * Entity Actions: More create button discernible text, extension of #20434 by @OskarKruger in umbraco/Umbraco-CMS#20458 * Header: Adjusted button focus border color contrast by @MrHutmat in umbraco/Umbraco-CMS#20562 * Login: Added custom validation for missing password and user/email on the login form by @MrHutmat in umbraco/Umbraco-CMS#20233 * Accessibility: Adding a label attribute for `<uui-button>` in news dashboard by @MrHutmat in umbraco/Umbraco-CMS#20780 * Keyboard navigation: Return to opening element after modal close by @MrHutmat in umbraco/Umbraco-CMS#20782 ### 🚀 New Features * Preview: Allows changing the preview environment inside the preview app, and other UX changes that enhance the experience by @leekelleher in umbraco/Umbraco-CMS#20598 * Login: Adds show/hide password toggle by @MrHutmat in umbraco/Umbraco-CMS#20611 * Adds Clear Clipboard button & logic by @warrenbuckley in umbraco/Umbraco-CMS#20757 * Member types: Implement containers by @ronaldbarendse in umbraco/Umbraco-CMS#20706 * Log viewer: Improves search functionality and code quality by @iOvergaard in umbraco/Umbraco-CMS#20913 * Log Viewer: Enhances the donut chart to be responsive, link to log search, and show numbers directly by @iOvergaard in umbraco/Umbraco-CMS#20928 * Culture and Hostnames: Add ability to sort hostnames (closes #20691) by @MrHutmat in umbraco/Umbraco-CMS#20826 * Localization: Adds `termOrDefault()` method to accept a fallback value by @iOvergaard in umbraco/Umbraco-CMS#20947 * Block Grid: Sort mode by @leekelleher in umbraco/Umbraco-CMS#20869 * News Dashboard: Adding functionality to overwrite the cache duration by @NillasKA in umbraco/Umbraco-CMS#21064 * Block List: Sort mode by @leekelleher in umbraco/Umbraco-CMS#21060 * Extend RTE output in Delivery API for better support for multi-site URL resolution by @MiguelGuedelha in umbraco/Umbraco-CMS#20846 * Content Types: Introduce schema service to support future schema generation by @lauraneto in umbraco/Umbraco-CMS#21031 * Delivery API: Adding allow list for content types by @NillasKA in umbraco/Umbraco-CMS#21111 * Emails: Add `Expires` header by @rickbutterfield in umbraco/Umbraco-CMS#20285 * Indexing: Make the indexing batch size configurable by @kjac in umbraco/Umbraco-CMS#20543 * Media: Add protection to restrict access to media in recycle bin (closes #2931) by @AndyButland in umbraco/Umbraco-CMS#20378 * Collection: Introduce Collection Item Card extension type by @madsrasmussen in umbraco/Umbraco-CMS#20954 * Collection: Introduce Collection Item Ref extension type by @madsrasmussen in umbraco/Umbraco-CMS#20994 ... (truncated) ## 17.1.0-rc ## What's Changed ### 📦 Dependencies * Dependencies: Fixed dependency conflicts when installing Microsoft.EntityFrameworkCore.Design (closes #20421) by @lauraneto in umbraco/Umbraco-CMS#20474 * Dependencies: Remove `Microsoft.CodeAnalysis.CSharp` dependency from Umbraco.Infrastructure by @lauraneto in umbraco/Umbraco-CMS#20481 * build(deps): bumps @umbraco-ui/uui from 1.16.0-rc.0 to 1.16.0 by @iOvergaard in umbraco/Umbraco-CMS#20535 * Bump vite from 7.1.9 to 7.1.11 in /src/Umbraco.Web.UI.Client by @dependabot[bot] in umbraco/Umbraco-CMS#20580 * Bump vite from 7.1.9 to 7.1.11 in /src/Umbraco.Web.UI.Login by @dependabot[bot] in umbraco/Umbraco-CMS#20621 * Bump playwright and @playwright/test in /tests/Umbraco.Tests.AcceptanceTest by @dependabot[bot] in umbraco/Umbraco-CMS#20579 * Bump the npm_and_yarn group across 2 directories with 1 update by @dependabot[bot] in umbraco/Umbraco-CMS#20863 * Dependencies: Updates some dependencies to latest minor or patch releases by @AndyButland in umbraco/Umbraco-CMS#20953 * build(deps): bumps monaco-editor from 0.54.0 to 0.55.1 by @iOvergaard in umbraco/Umbraco-CMS#21054 ### 🌈 Accessibility Improvements * Entity Actions: Create button discernible text (fixes #20205) by @OskarKruger in umbraco/Umbraco-CMS#20434 * Entity Actions: More create button discernible text, extension of #20434 by @OskarKruger in umbraco/Umbraco-CMS#20458 * Header: Adjusted button focus border color contrast by @MrHutmat in umbraco/Umbraco-CMS#20562 * Login: Added custom validation for missing password and user/email on the login form by @MrHutmat in umbraco/Umbraco-CMS#20233 * Accessibility: Adding a label attribute for `<uui-button>` in news dashboard by @MrHutmat in umbraco/Umbraco-CMS#20780 * Keyboard navigation: Return to opening element after modal close by @MrHutmat in umbraco/Umbraco-CMS#20782 ### 🚀 New Features * Preview: Allows changing the preview environment inside the preview app, and other UX changes that enhance the experience by @leekelleher in umbraco/Umbraco-CMS#20598 * Login: Adds show/hide password toggle by @MrHutmat in umbraco/Umbraco-CMS#20611 * Adds Clear Clipboard button & logic by @warrenbuckley in umbraco/Umbraco-CMS#20757 * Member types: Implement containers by @ronaldbarendse in umbraco/Umbraco-CMS#20706 * Log viewer: Improves search functionality and code quality by @iOvergaard in umbraco/Umbraco-CMS#20913 * Log Viewer: Enhances the donut chart to be responsive, link to log search, and show numbers directly by @iOvergaard in umbraco/Umbraco-CMS#20928 * Culture and Hostnames: Add ability to sort hostnames (closes #20691) by @MrHutmat in umbraco/Umbraco-CMS#20826 * Localization: Adds `termOrDefault()` method to accept a fallback value by @iOvergaard in umbraco/Umbraco-CMS#20947 * Block Grid: Sort mode by @leekelleher in umbraco/Umbraco-CMS#20869 * News Dashboard: Adding functionality to overwrite the cache duration by @NillasKA in umbraco/Umbraco-CMS#21064 * Block List: Sort mode by @leekelleher in umbraco/Umbraco-CMS#21060 * Extend RTE output in Delivery API for better support for multi-site URL resolution by @MiguelGuedelha in umbraco/Umbraco-CMS#20846 * Content Types: Introduce schema service to support future schema generation by @lauraneto in umbraco/Umbraco-CMS#21031 * Delivery API: Adding allow list for content types by @NillasKA in umbraco/Umbraco-CMS#21111 * Emails: Add `Expires` header by @rickbutterfield in umbraco/Umbraco-CMS#20285 * Indexing: Make the indexing batch size configurable by @kjac in umbraco/Umbraco-CMS#20543 * Media: Add protection to restrict access to media in recycle bin (closes #2931) by @AndyButland in umbraco/Umbraco-CMS#20378 * Collection: Introduce Collection Item Card extension type by @madsrasmussen in umbraco/Umbraco-CMS#20954 * Collection: Introduce Collection Item Ref extension type by @madsrasmussen in umbraco/Umbraco-CMS#20994 * Collection: Introduce Card and Ref Collection View kinds by @madsrasmussen in umbraco/Umbraco-CMS#21037 ### 🚤 Performance * Performance: Optimize memory footprint of document URL cache (closes #21055) by @AndyButland in umbraco/Umbraco-CMS#21066 * Distributed Background Jobs: Improve distributed background job locking behavior and performance by @nikolajlauridsen in umbraco/Umbraco-CMS#21100 * Repositories: Optimize repository caches to populate for both int and GUID keys by @AndyButland in umbraco/Umbraco-CMS#21124 * Performance: Re-introduce lazy locks by @lauraneto in umbraco/Umbraco-CMS#21102 ### 🐛 Bug Fixes ... (truncated) Commits viewable in [compare view](umbraco/Umbraco-CMS@release-17.0.2...release-17.1.0). </details> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Updated [Umbraco.Cms.DevelopmentMode.Backoffice](https://github.com/umbraco/Umbraco-CMS) from 17.0.2 to 17.1.0. <details> <summary>Release notes</summary> _Sourced from [Umbraco.Cms.DevelopmentMode.Backoffice's releases](https://github.com/umbraco/Umbraco-CMS/releases)._ ## 17.1.0 # What's Changed Since 17.1.0-rc ### 🐛 Bug Fixes * Media: Fix files not deleted from disk when recycle bin protection is enabled by @AndyButland in umbraco/Umbraco-CMS#21309 * Document Editing: Refactor of Fix property variation change breaking document save via Infinite Editing (closes #21195) by @nielslyngsoe in umbraco/Umbraco-CMS#21293 * umbraco/Umbraco-CMS#21306 by @calm329 in umbraco/Umbraco-CMS#21306 **Full Changelog**: umbraco/Umbraco-CMS@release-17.1.0-rc...release-17.1.0 ## What's Changed Since the Last Release (17.0.2) ### 📦 Dependencies * Dependencies: Fixed dependency conflicts when installing Microsoft.EntityFrameworkCore.Design (closes #20421) by @lauraneto in umbraco/Umbraco-CMS#20474 * Dependencies: Remove `Microsoft.CodeAnalysis.CSharp` dependency from Umbraco.Infrastructure by @lauraneto in umbraco/Umbraco-CMS#20481 * build(deps): bumps @umbraco-ui/uui from 1.16.0-rc.0 to 1.16.0 by @iOvergaard in umbraco/Umbraco-CMS#20535 * Bump vite from 7.1.9 to 7.1.11 in /src/Umbraco.Web.UI.Client by @dependabot[bot] in umbraco/Umbraco-CMS#20580 * Bump vite from 7.1.9 to 7.1.11 in /src/Umbraco.Web.UI.Login by @dependabot[bot] in umbraco/Umbraco-CMS#20621 * Bump playwright and @playwright/test in /tests/Umbraco.Tests.AcceptanceTest by @dependabot[bot] in umbraco/Umbraco-CMS#20579 * Bump the npm_and_yarn group across 2 directories with 1 update by @dependabot[bot] in umbraco/Umbraco-CMS#20863 * Dependencies: Updates some dependencies to latest minor or patch releases by @AndyButland in umbraco/Umbraco-CMS#20953 * build(deps): bumps monaco-editor from 0.54.0 to 0.55.1 by @iOvergaard in umbraco/Umbraco-CMS#21054 ### 🌈 Accessibility Improvements * Entity Actions: Create button discernible text (fixes #20205) by @OskarKruger in umbraco/Umbraco-CMS#20434 * Entity Actions: More create button discernible text, extension of #20434 by @OskarKruger in umbraco/Umbraco-CMS#20458 * Header: Adjusted button focus border color contrast by @MrHutmat in umbraco/Umbraco-CMS#20562 * Login: Added custom validation for missing password and user/email on the login form by @MrHutmat in umbraco/Umbraco-CMS#20233 * Accessibility: Adding a label attribute for `<uui-button>` in news dashboard by @MrHutmat in umbraco/Umbraco-CMS#20780 * Keyboard navigation: Return to opening element after modal close by @MrHutmat in umbraco/Umbraco-CMS#20782 ### 🚀 New Features * Preview: Allows changing the preview environment inside the preview app, and other UX changes that enhance the experience by @leekelleher in umbraco/Umbraco-CMS#20598 * Login: Adds show/hide password toggle by @MrHutmat in umbraco/Umbraco-CMS#20611 * Adds Clear Clipboard button & logic by @warrenbuckley in umbraco/Umbraco-CMS#20757 * Member types: Implement containers by @ronaldbarendse in umbraco/Umbraco-CMS#20706 * Log viewer: Improves search functionality and code quality by @iOvergaard in umbraco/Umbraco-CMS#20913 * Log Viewer: Enhances the donut chart to be responsive, link to log search, and show numbers directly by @iOvergaard in umbraco/Umbraco-CMS#20928 * Culture and Hostnames: Add ability to sort hostnames (closes #20691) by @MrHutmat in umbraco/Umbraco-CMS#20826 * Localization: Adds `termOrDefault()` method to accept a fallback value by @iOvergaard in umbraco/Umbraco-CMS#20947 * Block Grid: Sort mode by @leekelleher in umbraco/Umbraco-CMS#20869 * News Dashboard: Adding functionality to overwrite the cache duration by @NillasKA in umbraco/Umbraco-CMS#21064 * Block List: Sort mode by @leekelleher in umbraco/Umbraco-CMS#21060 * Extend RTE output in Delivery API for better support for multi-site URL resolution by @MiguelGuedelha in umbraco/Umbraco-CMS#20846 * Content Types: Introduce schema service to support future schema generation by @lauraneto in umbraco/Umbraco-CMS#21031 * Delivery API: Adding allow list for content types by @NillasKA in umbraco/Umbraco-CMS#21111 * Emails: Add `Expires` header by @rickbutterfield in umbraco/Umbraco-CMS#20285 * Indexing: Make the indexing batch size configurable by @kjac in umbraco/Umbraco-CMS#20543 * Media: Add protection to restrict access to media in recycle bin (closes #2931) by @AndyButland in umbraco/Umbraco-CMS#20378 * Collection: Introduce Collection Item Card extension type by @madsrasmussen in umbraco/Umbraco-CMS#20954 * Collection: Introduce Collection Item Ref extension type by @madsrasmussen in umbraco/Umbraco-CMS#20994 ... (truncated) ## 17.1.0-rc ## What's Changed ### 📦 Dependencies * Dependencies: Fixed dependency conflicts when installing Microsoft.EntityFrameworkCore.Design (closes #20421) by @lauraneto in umbraco/Umbraco-CMS#20474 * Dependencies: Remove `Microsoft.CodeAnalysis.CSharp` dependency from Umbraco.Infrastructure by @lauraneto in umbraco/Umbraco-CMS#20481 * build(deps): bumps @umbraco-ui/uui from 1.16.0-rc.0 to 1.16.0 by @iOvergaard in umbraco/Umbraco-CMS#20535 * Bump vite from 7.1.9 to 7.1.11 in /src/Umbraco.Web.UI.Client by @dependabot[bot] in umbraco/Umbraco-CMS#20580 * Bump vite from 7.1.9 to 7.1.11 in /src/Umbraco.Web.UI.Login by @dependabot[bot] in umbraco/Umbraco-CMS#20621 * Bump playwright and @playwright/test in /tests/Umbraco.Tests.AcceptanceTest by @dependabot[bot] in umbraco/Umbraco-CMS#20579 * Bump the npm_and_yarn group across 2 directories with 1 update by @dependabot[bot] in umbraco/Umbraco-CMS#20863 * Dependencies: Updates some dependencies to latest minor or patch releases by @AndyButland in umbraco/Umbraco-CMS#20953 * build(deps): bumps monaco-editor from 0.54.0 to 0.55.1 by @iOvergaard in umbraco/Umbraco-CMS#21054 ### 🌈 Accessibility Improvements * Entity Actions: Create button discernible text (fixes #20205) by @OskarKruger in umbraco/Umbraco-CMS#20434 * Entity Actions: More create button discernible text, extension of #20434 by @OskarKruger in umbraco/Umbraco-CMS#20458 * Header: Adjusted button focus border color contrast by @MrHutmat in umbraco/Umbraco-CMS#20562 * Login: Added custom validation for missing password and user/email on the login form by @MrHutmat in umbraco/Umbraco-CMS#20233 * Accessibility: Adding a label attribute for `<uui-button>` in news dashboard by @MrHutmat in umbraco/Umbraco-CMS#20780 * Keyboard navigation: Return to opening element after modal close by @MrHutmat in umbraco/Umbraco-CMS#20782 ### 🚀 New Features * Preview: Allows changing the preview environment inside the preview app, and other UX changes that enhance the experience by @leekelleher in umbraco/Umbraco-CMS#20598 * Login: Adds show/hide password toggle by @MrHutmat in umbraco/Umbraco-CMS#20611 * Adds Clear Clipboard button & logic by @warrenbuckley in umbraco/Umbraco-CMS#20757 * Member types: Implement containers by @ronaldbarendse in umbraco/Umbraco-CMS#20706 * Log viewer: Improves search functionality and code quality by @iOvergaard in umbraco/Umbraco-CMS#20913 * Log Viewer: Enhances the donut chart to be responsive, link to log search, and show numbers directly by @iOvergaard in umbraco/Umbraco-CMS#20928 * Culture and Hostnames: Add ability to sort hostnames (closes #20691) by @MrHutmat in umbraco/Umbraco-CMS#20826 * Localization: Adds `termOrDefault()` method to accept a fallback value by @iOvergaard in umbraco/Umbraco-CMS#20947 * Block Grid: Sort mode by @leekelleher in umbraco/Umbraco-CMS#20869 * News Dashboard: Adding functionality to overwrite the cache duration by @NillasKA in umbraco/Umbraco-CMS#21064 * Block List: Sort mode by @leekelleher in umbraco/Umbraco-CMS#21060 * Extend RTE output in Delivery API for better support for multi-site URL resolution by @MiguelGuedelha in umbraco/Umbraco-CMS#20846 * Content Types: Introduce schema service to support future schema generation by @lauraneto in umbraco/Umbraco-CMS#21031 * Delivery API: Adding allow list for content types by @NillasKA in umbraco/Umbraco-CMS#21111 * Emails: Add `Expires` header by @rickbutterfield in umbraco/Umbraco-CMS#20285 * Indexing: Make the indexing batch size configurable by @kjac in umbraco/Umbraco-CMS#20543 * Media: Add protection to restrict access to media in recycle bin (closes #2931) by @AndyButland in umbraco/Umbraco-CMS#20378 * Collection: Introduce Collection Item Card extension type by @madsrasmussen in umbraco/Umbraco-CMS#20954 * Collection: Introduce Collection Item Ref extension type by @madsrasmussen in umbraco/Umbraco-CMS#20994 * Collection: Introduce Card and Ref Collection View kinds by @madsrasmussen in umbraco/Umbraco-CMS#21037 ### 🚤 Performance * Performance: Optimize memory footprint of document URL cache (closes #21055) by @AndyButland in umbraco/Umbraco-CMS#21066 * Distributed Background Jobs: Improve distributed background job locking behavior and performance by @nikolajlauridsen in umbraco/Umbraco-CMS#21100 * Repositories: Optimize repository caches to populate for both int and GUID keys by @AndyButland in umbraco/Umbraco-CMS#21124 * Performance: Re-introduce lazy locks by @lauraneto in umbraco/Umbraco-CMS#21102 ### 🐛 Bug Fixes ... (truncated) Commits viewable in [compare view](umbraco/Umbraco-CMS@release-17.0.2...release-17.1.0). </details> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Alexander Seeliger <[email protected]>
Prerequisites
This fixes #21300
Description
Problem:
When clicking the Login button without entering credentials, validation messages were not displayed. Users only saw validation errors after focusing on the input fields first.
Solution:
Added
oninvalidevent handlers to both username and password inputs inauth.element.ts. Theinvalidevent fires automatically whencheckValidity()is called on a form with invalid inputs, triggering the existingvalidateInput()function to display error messages.Changes:
src/Umbraco.Web.UI.Login/src/auth.element.ts: Addedinput.oninvalidhandlers increateFormLayoutItem()andcreateFormLayoutPasswordItem()How to test:
Contribution by Gittensor, see my contribution statistics at https://gittensor.io/miners/details?githubId=148254234