Skip to content

Packaging: Fixing bad serialization for data types in packages #21043

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
NillasKA merged 2 commits into from
Dec 4, 2025
Merged

Packaging: Fixing bad serialization for data types in packages #21043

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a1a6675
Changing data type serialization to datatype
NillasKA Dec 3, 2025
ffd3e40
Moving and correcting comment
NillasKA Dec 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion src/Umbraco.Core/Services/EntityXmlSerializer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -214,7 +214,7 @@ public XElement Serialize(IDataType dataType)
xml.Add(new XAttribute("EditorUiAlias", dataType.EditorUiAlias ?? dataType.EditorAlias));
xml.Add(new XAttribute("Definition", dataType.Key));
xml.Add(new XAttribute("DatabaseType", dataType.DatabaseType.ToString()));
xml.Add(new XAttribute("Configuration", _configurationEditorJsonSerializer.Serialize(dataType.ConfigurationObject)));
xml.Add(new XAttribute("Configuration", SerializeDataTypeConfiguration(dataType)));

var folderNames = string.Empty;
var folderKeys = string.Empty;
Expand Down Expand Up @@ -708,4 +708,14 @@ private void SerializeChildren(IEnumerable<IMedia> children, XElement xml, Actio
}
}
}

/// <summary>
/// We have two properties containing configuration data:
/// 1. ConfigurationData - a dictionary that contains all the configuration data stored as key/value pairs.
/// 2. ConfigurationObject - a strongly typed object that represents the configuration data known to the server.
/// To fully be able to restore the package, we need to serialize the full ConfigurationData dictionary, not
/// just the configuration properties known to the server.
/// </summary>
private string SerializeDataTypeConfiguration(IDataType dataType) =>
_configurationEditorJsonSerializer.Serialize(dataType.ConfigurationData);
}
Loading