Packaging: Fixing bad serialization for data types in packages#21043
Merged
Packaging: Fixing bad serialization for data types in packages#21043
Conversation
Zeegaan
approved these changes
Dec 4, 2025
Member
Zeegaan
left a comment
There was a problem hiding this comment.
Looks good to me 👍
Maybe a little overkill with a method just used once, but I think the clarifying comment is nice 😁
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Messed my previous PR up a bit, so heres a new clean one.
Previous PR #20969
Closing #20801
Description
An issue was raised, that pointed out that when creating and downloading a package from the backoffice. The blocklist data type did not contain any other properties on a block, other than 2 IDs. The missing property mentioned in the issue was the label, however i found that a bunch of other properties were missing as well.
The initial fix for this was to manually add these properties to the configuration classes of our property editors. However this could introduce difficulties in the long run, as we'd have to maintain these configurations and keep them up to date with the frontend.
The other fix was to change the serialization to serialize the
ConfigurationDatarather than theConfigurationObject. With this change in place all properties should be included in the downloaded package.xml file that appears when downloading a newly created package.How do you test it?
Step by step: