Skip to content

V14: Lock out users#16199

Merged
elit0451 merged 1 commit intov14/devfrom
v14/bugfix/lock-out-users
May 1, 2024
Merged

V14: Lock out users#16199
elit0451 merged 1 commit intov14/devfrom
v14/bugfix/lock-out-users

Conversation

@Zeegaan
Copy link
Member

@Zeegaan Zeegaan commented May 1, 2024

Notes

  • Remove the validation of credentials first, as this is not needed.
    Brif history on why: it's because deploy needed a way to validate credentials, without logging the user in, thus ValidateCredentialsAsync was created.
    Thus it is safe to remove this validation, as PasswordSignInAsync will validate the password, increment the lockout count etc all on its own.

How to test

  • Create a new user (remember the email and password)
  • Log in with the user just to activate it
  • Log out again
  • Try to log in with the WRONG password more than 5 times
  • Try to log in with the right password, this should now fail as the user is locked out 😁

@elit0451 elit0451 merged commit bad2110 into v14/dev May 1, 2024
@elit0451 elit0451 deleted the v14/bugfix/lock-out-users branch May 1, 2024 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants