Login flow in v14 will ignore failed access

[russellshome]

Which Umbraco version are you using? (Please write the exact version, example: 10.1.0)

14

Bug summary

Users will never be locked out.

Specifics

This line of code returns before running PasswordSign. However PasswordSign is where changes such as number of failed attempts is updated.

Umbraco-CMS/src/Umbraco.Cms.Api.Management/Controllers/Security/BackOfficeController.cs

Line 72 in d418802

return Unauthorized();

Steps to reproduce

Try to login with incorrect password more than 5 times.

Expected result / actual result

Expected: user locked out
Actual: user is not locked out.

[github-actions]

Hi there @russellshome!

Firstly, a big thank you for raising this issue. Every piece of feedback we receive helps us to make Umbraco better.

We really appreciate your patience while we wait for our team to have a look at this but we wanted to let you know that we see this and share with you the plan for what comes next.

• We'll assess whether this issue relates to something that has already been fixed in a later version of the release that it has been raised for.
• If it's a bug, is it related to a release that we are actively supporting or is it related to a release that's in the end-of-life or security-only phase?
• We'll replicate the issue to ensure that the problem is as described.
• We'll decide whether the behavior is an issue or if the behavior is intended.

We wish we could work with everyone directly and assess your issue immediately but we're in the fortunate position of having lots of contributions to work with and only a few humans who are able to do it. We are making progress though and in the meantime, we will keep you in the loop and let you know when we have any questions.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

[Zeegaan]

I can definitely reproduce this, I've created a fix here: #16199