Avoid string.Format allocations by ProfilingViewEngine when profiler is not enabled.#15859
Conversation
|
Hi there @nzdev, thank you for this contribution! 👍 While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:
Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution. If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request. Thanks, from your friendly Umbraco GitHub bot 🤖 🙂 |
|
Hey @nzdev, thanks a lot for your PR 😄 someone on the Core Collaborators team will review this soon! |
|
Thanks @nzdev! |
Prerequisites
If there's an existing issue for this PR then this fixes
Description
Each time ProfilingViewEngine.FindView and ProfilingViewEngine.GetView is called (each time a view is used) the ProfilingViewEngine calls string.Format for a log message as part of profiling. However, if Umbraco is not in debug mode, this is unnecessary as the IProfiler will be a NoOp and will discard the formatted string, however this formatted string is still allocated.
This PR adds a IsEnabled property to IProfiler, so the string.Format allocations can be avoided when the IProfiler is not enabled.
How to test?
Check that IProfiler.Step is not called when IProfiler is not enabled.