Avoid string.Format allocations when profiler is not enabled.

Author: nzdev

src/Umbraco.Core/Logging/IProfiler.cs

@@ -27,4 +27,9 @@ public interface IProfiler
     ///     authenticated or you want to clear the results, based upon some other mechanism.
     /// </remarks>
     void Stop(bool discardResults = false);
+
+    /// <summary>
+    /// Whether the profiler is enabled.
+    /// </summary>
+    bool IsEnabled => true;
 }

src/Umbraco.Core/Logging/LogProfiler.cs

@@ -35,6 +35,9 @@ public void Stop(bool discardResults = false)
         // the log never stops
     }
 
+    /// <inheritdoc />
+    public bool IsEnabled => _logger.IsEnabled(Microsoft.Extensions.Logging.LogLevel.Debug);
+
     // a lightweight disposable timer
     private class LightDisposableTimer : DisposableObjectSlim
     {

src/Umbraco.Core/Logging/NoopProfiler.cs

@@ -14,6 +14,9 @@ public void Stop(bool discardResults = false)
     {
     }
 
+    /// <inheritdoc/>
+    public bool IsEnabled => false;
+
     private class VoidDisposable : DisposableObjectSlim
     {
         protected override void DisposeResources()

src/Umbraco.Web.Common/Profiler/WebProfiler.cs

@@ -24,6 +24,9 @@ public class WebProfiler : IProfiler
     private int _first;
     private MiniProfiler? _startupProfiler;
 
+    /// <inheritdoc />
+    public bool IsEnabled => true;
+
     public IDisposable? Step(string name) => MiniProfiler.Current?.Step(name);
 
     public void Start()

src/Umbraco.Web.Website/ViewEngines/ProfilingViewEngine.cs

@@ -19,15 +19,15 @@ public ProfilingViewEngine(IViewEngine inner, IProfiler profiler)
 
     public ViewEngineResult FindView(ActionContext context, string viewName, bool isMainPage)
     {
-        using (_profiler.Step(string.Format("{0}.FindView, {1}, {2}", _name, viewName, isMainPage)))
+        using (_profiler.IsEnabled ? _profiler.Step(string.Format("{0}.FindView, {1}, {2}", _name, viewName, isMainPage)) : null)
         {
             return WrapResult(Inner.FindView(context, viewName, isMainPage));
         }
     }
 
     public ViewEngineResult GetView(string? executingFilePath, string viewPath, bool isMainPage)
     {
-        using (_profiler.Step(string.Format("{0}.GetView, {1}, {2}, {3}", _name, executingFilePath, viewPath, isMainPage)))
+        using (_profiler.IsEnabled ? _profiler.Step(string.Format("{0}.GetView, {1}, {2}, {3}", _name, executingFilePath, viewPath, isMainPage)) : null)
         {
             return Inner.GetView(executingFilePath, viewPath, isMainPage);
         }

tests/Umbraco.Tests.Common/TestHelpers/Stubs/TestProfiler.cs

@@ -39,6 +39,9 @@ public void Stop(bool discardResults = false)
         }
     }
 
+    /// <inheritdoc/>
+    public bool IsEnabled => _enabled;
+
     public static void Enable() => _enabled = true;
 
     public static void Disable() => _enabled = false;