Skip to content

[vlsi][ci skip] Fix tutorial.mk so that INPUT_CONFS override only affects tutorials#1631

Merged
jerryz123 merged 1 commit intomainfrom
jerryz123-patch-5
Oct 19, 2023
Merged

[vlsi][ci skip] Fix tutorial.mk so that INPUT_CONFS override only affects tutorials#1631
jerryz123 merged 1 commit intomainfrom
jerryz123-patch-5

Conversation

@jerryz123
Copy link
Copy Markdown
Contributor

@jerryz123 jerryz123 commented Oct 19, 2023

Previously, this unintuitively overrode the INPUT_CONFS in vlsi/Makefile in all cases.

Related PRs / Issues:

Type of change:

  • Bug fix
  • New feature
  • Other enhancement

Impact:

  • RTL change
  • Software change (RISC-V software)
  • Build system change
  • Other

Contributor Checklist:

  • Did you set main as the base branch?
  • Is this PR's title suitable for inclusion in the changelog and have you added a changelog:<topic> label?
  • Did you state the type-of-change/impact?
  • Did you delete any extraneous prints/debugging code?
  • Did you mark the PR with a changelog: label?
  • (If applicable) Did you update the conda .conda-lock.yml file if you updated the conda requirements file?
  • (If applicable) Did you add documentation for the feature?
  • (If applicable) Did you add a test demonstrating the PR?
  • (If applicable) Did you mark the PR as Please Backport?

@jerryz123 jerryz123 merged commit f80426e into main Oct 19, 2023
@jerryz123 jerryz123 deleted the jerryz123-patch-5 branch November 8, 2023 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants