Conversation
T-K-233
approved these changes
May 13, 2023
Member
T-K-233
left a comment
There was a problem hiding this comment.
Looks good!
It would be better if we name "serialManager*" as "serialTLManager*", but I think this is also fine.
Contributor
Author
That a good idea. I'll make that change |
abejgonzalez
approved these changes
May 14, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change fixes support for configs in which the TLSerdesser is unidirectional; that is, cases in which the chip acts as only the manager, and off chip acts as only the client.
This simplifies the memory map for all default designs as we no longer have to add a stub off-chip memory to provide the chip-client/harness-manager link.
Why not use the existing
TLDesser/TLSerder, which already do this? Those IMO can be deleted as their implementations are now supported by the generalizedTLSerdesser.Since we support configs now where the serializer only acts as a client to the FBus, a bunch of
WithSerialPBusMemfragments can be removed, as these were used to specify where the stub tilelink device sat.Related PRs / Issues:
Type of change:
Impact:
Contributor Checklist:
mainas the base branch?changelog:<topic>label?changelog:label?.conda-lock.ymlfile if you updated the conda requirements file?Please Backport?