fix: filter held snaps from update available list (#1983)#2061
Open
gauravsaini wants to merge 1 commit intoubuntu:mainfrom
Open
fix: filter held snaps from update available list (#1983)#2061gauravsaini wants to merge 1 commit intoubuntu:mainfrom
gauravsaini wants to merge 1 commit intoubuntu:mainfrom
Conversation
Snaps that have been held via 'snap refresh --hold' should not appear in the updates available list. Added check for snap.hold field to filter out snaps with active hold.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
snap refresh --holdare now excluded from the updates available listProblem
When a snap's updates are manually held (via
snap refresh snapName --hold), the snap still appeared in the App Center's "Updates available" list. This is confusing because the user explicitly held the update.Fix
Added a filter in
fetchRefreshableSnaps()to exclude snaps wheresnap.holdis set and in the future. Theholdfield on theSnapclass indicates when updates are held until, so we check ifholdis null or has passed.Testing
snap refresh --hold <snap-name>