Skip to content

Add type hints to all test code #1217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 31, 2022

Conversation

intgr
Copy link
Collaborator

@intgr intgr commented Oct 30, 2022

As discussed in #1206, I have added type hints to all test code. This PR should be merged first.

Copy link
Member

@sobolevn sobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your amazing work!

@intgr intgr force-pushed the add-hints-to-all-test-code branch from f271a97 to 2bbb63b Compare October 31, 2022 08:20
@intgr intgr requested a review from sobolevn October 31, 2022 08:22
Copy link
Member

@sobolevn sobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sobolevn sobolevn merged commit e3c131b into typeddjango:master Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants