Fill remaining missing hints with Any & disallow partial hints

[intgr]

This one just adds Any to all the remaining missing hints (most of those files are unhinted anyway) and disallows partial hints in mypy.ini

disallow_untyped_defs = true
disallow_incomplete_defs = true

[sobolevn]

@intgr can you please solve merge conflicts? And I can then start reviewing it :)

[intgr]

I'm unsure what these owner fields are.

[flaeppe]

I think it's type[M] | None = None (if not in pyi)

Where

M = TypeVar("M", bound=Model)

And I think it's not none when instance is not none.

Making this an @overload function

[flaeppe]

So in this specific overload both any's should be : None I think

[intgr]

@flaeppe You're probably right but I'm wary of touching these since I don't totally understand what is happening here. Are you up for opening a follow-up PR?

[flaeppe]

I think it should be fine keeping it as Any since what's exposed as an API is _T. The instance and owner types would only be relevant for the implementation body, but this is in stubs so we won't be affected here.

The only time they'd come in to play and have an impact would be while/if subclassing Field and overriding it's descriptor methods. If we keep Any, we'll allow a child class to declare them as whatever type they deem fit, while doing e.g. type[M] | None we'll restrain it.

Though, in general I don't see any obvious use cases for overriding the descriptor for Field, but I might be wrong here. The normal Django use case would be to implement a separate field descriptor class (https://docs.djangoproject.com/en/4.1/ref/models/fields/#django.db.models.Field.descriptor_class) to decide what goes in and out of a model field

[intgr]

def __len__(self) -> Any: ...

Technically it is always int

The idea here was to fill in all missing hints so that we could increase the strictness in mypy.ini, to make sure people don't forget to add hints to new arguments or return values in the future.

I'm not making anything worse because Any was implied already before for all these unhinted items.

I suppose I could do manual tweaks here and there, but it's increasing the scope of a change that's already enormous. Is that what we want?

[sobolevn]

I'm not making anything worse because Any

Ok!

[adamchainz]

I'm okay with this, but after merging, can you open an issue or PR for -> int on all __len__ methods? autotyping can also help with adding some type hints automatically.

[sobolevn]

is it ready to be reviewed? or should we merge tests first?

[intgr]

It contains all changes from the other PR also. But other than that it should be ready.

[sobolevn]

I've merged test changes, there are conflicts now 👀

[intgr]

Rebased.

[sobolevn]

Thanks again! Maybe someone else will have some extra input.

[adamchainz]

LGTM as a step towards stricter Mypy config.