[pull] master from php:master #207
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
* PHP-8.4: Fix GH-18744: PHP 8.4 classList works not correctly if copy HTMLElement by clone keyword.
This API can't handle references, yet everyone keeps forgetting that it can't and that you should DEREF upfront. Fix every type of this issue once and for all by moving the reference handling to this Zend API. Closes GH-18761.
* PHP-8.4: Fix handling of references in zval_try_get_long()
strlen() operates on NUL-terminated strings, writing a NUL byte at the strlen offset accomplishes nothing but wasting cycles.
This issue happens because http wrapper sets peer_name but then does not remove so it stays in the context. The fix removes the peer name from the context after enabling crypto. In addition to bug #74796, this also fixes bug #76196. In addition it should be a final fix for those SOAP bugs: bug #69783 bug #52913 bug #61463
On certain platform an unsigned int is 64bits, which is not needed.
* PHP-8.3: Fix compile without ZEND_MM_STORAGE
* PHP-8.4: Fix compile without ZEND_MM_STORAGE
Update to PHP-Parser 5.5.0 and add support for attributes on constants in stubs. For now, I have only migrated over E_STRICT, once the support is in place I'll do a larger migration of the existing deprecated constants. In the process, fix the logic in `copy_zend_constant()` for copying attributes when a constant is copied; just increase the reference count for the attributes table rather than trying to duplicate the contents.
This is a continuation of GH-18927 to fix CI for windows-2022
This is a continuation of GH-18927 to fix CI for windows-2022
* PHP-8.2: Fix CI for windows-2022
* PHP-8.3: Fix CI for windows-2022
* PHP-8.4: Fix CI for windows-2022
…18780) Only covers constants declared via stub files, others will be handled separately in a later commit. Does not include the intl extension, since that had some errors relating to the cpp code; that extension will be updated separately.
ParentNode::$children returns a HTMLCollection of all directly descendant child elements of a container. I had to move around some properties such that the ParentNode property offsets are always at a fixed offset, to simplify the code. This also adds the necessary code to deal with GC cycles in HTMLCollections. Furthermore, we also disable cloning a HTMLCollection as that never worked and furthermore it also conflicts with the [[SameObject]] WebIDL requirement of $children.
* PHP-8.3: Fix pcntl_rfork / pcntl_forkx with zend-max-execution-timers
* PHP-8.4: Fix pcntl_rfork / pcntl_forkx with zend-max-execution-timers
This macro was introduced to solve false compilers warning about the getThis() condition not making sense for the address-taken part of the ternary.
strcpy is a dangerous API that should be avoided.
The ptrdiff_t is a C89 standard type defined in `<stddef.h>` and widely available on current platforms. Using it conditionally as in these occurrences is not needed anymore.
adding with its own remainder, INT_MAX overflows here (negative values are discarded). close GH-18977
The intmax_t is a C99 standard type defined in `<stdint.h>` and widely available on current platforms. On Windows they are available as of Visual Studio 2013. Using it conditionally as in these occurrences is not needed anymore.
Current minimum PCRE2 library in PHP is 10.30 (with bundled 10.45) and none of these versions use PCRE_STATIC macro anymore in favor of PCRE2_STATIC, which is defined in the generated config.w32.h on Windows.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.1)
Can you help keep this open source service alive? 💖 Please sponsor : )