Remove HAVE_PTRDIFF_T and SIZEOF_PTRDIFF_T #18968
Merged
+4
−33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ptrdiff_t is a C89 standard type defined in `<stddef.h>` and widely available on current platforms. Using it conditionally as in these occurrences is not needed anymore.
|
Thanks @devnexen for the review. Merged "already" as I'm pretty sure this change is fine and I need it for another PR. |
Girgias
reviewed
Jun 29, 2025
| @@ -454,7 +454,6 @@ AC_CHECK_TYPES([socklen_t], [], [], [ | |||
| dnl These are defined elsewhere than stdio.h. | |||
| PHP_CHECK_SIZEOF([intmax_t], [0]) | |||
There was a problem hiding this comment.
Potential follow-up, we don't need to check for intmax_t as it is a C99 type and we require C99
Just saw you opened: #18971
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If I'm not mistaken... The ptrdiff_t is a C89 standard type defined in
<stddef.h>and widely available on current platforms. Using it conditionally as in these occurrences is not needed anymore.