subscriber: allow ansi sanitization to be disabled#3484
Merged
hds merged 4 commits intotokio-rs:mainfrom Mar 12, 2026
Merged
Conversation
hds
requested changes
Mar 7, 2026
Contributor
hds
left a comment
There was a problem hiding this comment.
Thanks for taking in this PR! It's really appreciated!
I've got a naming question and perhaps another test needed?
6a39abc to
758c1cc
Compare
921dc05 to
55cce37
Compare
hds
added a commit
that referenced
this pull request
Mar 13, 2026
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: #3369
Add
ansi_sanitizationflag to allow turning off the sanitization of ansi output.Sanitizing output remains the default but can now be turned off.
Solution
ansi_sanitizationis passed into the newAnsiValuestruct which now replacesEscapetogether with avalue: T, when enabled will escape values with the same logic asEscaperelying onEscapingWriter.