Add skip security context flag in e2e script#1853
Merged
tekton-robot merged 2 commits intotektoncd:mainfrom Jul 4, 2025
Merged
Add skip security context flag in e2e script#1853tekton-robot merged 2 commits intotektoncd:mainfrom
tekton-robot merged 2 commits intotektoncd:mainfrom
Conversation
tekton-robot
added
the
release-note-none
tekton-robot
added
the
size/M
Contributor
Author
|
/test tekton-triggers-unit-tests |
khrm
force-pushed
the
skipContext
branch
2 times, most recently
from
c6a87fa to
6a2251e
Compare
| ko apply -f config/interceptors || fail_test "Core interceptors installation failed" | ||
| ko resolve -f config/interceptors > "${rel}" || fail_test "Core interceptors build failed" | ||
|
|
||
| if [ "${SKIP_SECURITY_CTX}" == "true" ]; then |
Contributor
There was a problem hiding this comment.
I think we are setting SKIP_SECURITY_CTX as false do we still need this change??
Contributor
Author
There was a problem hiding this comment.
I didn't get this. We need this when SKIP_SECURITY_CTX is true.
khrm
commented
Jul 4, 2025
| # instead of detecting the latest released one from tektoncd/pipeline releases | ||
| RELEASE_YAML=${RELEASE_YAML:-} | ||
|
|
||
| SKIP_SECURITY_CTX=${SKIP_SECURITY_CTX:="false"} |
Contributor
Author
There was a problem hiding this comment.
We set this here so that this file can be run independently.
This enables us to run e2e tests in environment where default security context is different.
Before there was no way to know which particular tests have failed without going through all logs. Now, it will print which tests have failed.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: savitaashture The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This enables us to run e2e tests in environment where default security context is different.
Changes
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
/kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes