Skip to content

Add skip security context flag in e2e script #1853

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tekton-robot merged 2 commits into from
Jul 4, 2025
Merged

Add skip security context flag in e2e script #1853

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f00c943
Add skip security context flag in e2e script
khrm Jul 3, 2025
55cb159
Print name of the tests which fail
khrm Jul 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 23 additions & 4 deletions test/e2e-common.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
# Check if we have a specific RELEASE_YAML global environment variable to use
# instead of detecting the latest released one from tektoncd/pipeline releases
RELEASE_YAML=${RELEASE_YAML:-}

SKIP_SECURITY_CTX=${SKIP_SECURITY_CTX:="false"}
Copy link
Contributor Author

@khrm khrm Jul 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We set this here so that this file can be run independently.

source $(dirname $0)/../vendor/github.com/tektoncd/plumbing/scripts/e2e-tests.sh

function install_pipeline_crd() {
Expand All @@ -52,18 +52,37 @@ function install_pipeline_crd() {

function install_triggers_crd() {
echo ">> Deploying Tekton Triggers"
ko apply -f config/ || fail_test "Tekton Triggers installation failed"
rel=$(mktemp)
release=$(mktemp)
ko resolve -f config/ > "${rel}" || fail_test "Tekton Triggers build failed"

if [ "${SKIP_SECURITY_CTX}" == "true" ]; then
yq 'del(.spec.template.spec.containers[]?.securityContext.runAsUser, .spec.template.spec.containers[]?.securityContext.runAsGroup)' "${rel}" > "${release}"
else
cat "${rel}" > "${release}"
fi

kubectl apply -f "${release}" || fail_test "Tekton Triggers installation failed"

# Wait for the Interceptors CRD to be available before adding the core-interceptors
kubectl wait --for=condition=Established --timeout=30s crds/clusterinterceptors.triggers.tekton.dev
ko apply -f config/interceptors || fail_test "Core interceptors installation failed"
ko resolve -f config/interceptors > "${rel}" || fail_test "Core interceptors build failed"

if [ "${SKIP_SECURITY_CTX}" == "true" ]; then
Copy link
Contributor

@savitaashture savitaashture Jul 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we are setting SKIP_SECURITY_CTX as false do we still need this change??

Copy link
Contributor Author

@khrm khrm Jul 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't get this. We need this when SKIP_SECURITY_CTX is true.

kubectl patch configmap config-defaults-triggers -n tekton-pipelines --type='merge' -p='{"data":{"default-run-as-user":"","default-fs-group":"", "default-run-as-group":""}}'
yq 'del(.spec.template.spec.containers[]?.securityContext.runAsUser, .spec.template.spec.containers[]?.securityContext.runAsGroup)' "${rel}" > "${release}"
else
cat "${rel}" > "${release}"
fi

kubectl apply -f "${release}" || fail_test "Core interceptors installation failed"

# Make sure that eveything is cleaned up in the current namespace.
for res in eventlistener triggertemplate triggerbinding clustertriggerbinding; do
kubectl delete --ignore-not-found=true ${res}.triggers.tekton.dev --all
done

rm -f "${rel}" "${release}"
# Wait for pods to be running in the namespaces we are deploying to
wait_until_pods_running tekton-pipelines || fail_test "Tekton Triggers did not come up"

}
13 changes: 8 additions & 5 deletions test/e2e-tests.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,9 @@ source $(dirname $0)/e2e-common.sh

# Setting defaults
failed=0

SKIP_INITIALIZE=${SKIP_INITIALIZE:="false"}
export SKIP_SECURITY_CTX=${SKIP_SECURITY_CTX:="false"}


if [ "${SKIP_INITIALIZE}" != "true" ]; then
Expand All @@ -34,18 +36,19 @@ install_pipeline_crd
install_triggers_crd

header "Running yaml tests"
$(dirname $0)/e2e-tests-yaml.sh || failed=1
$(dirname $0)/e2e-tests-yaml.sh || { failed=1 && echo "failed yaml tests"; }

header "Running ingress tests"
$(dirname $0)/e2e-tests-ingress.sh || failed=1
$(dirname $0)/e2e-tests-ingress.sh || { failed=1 && echo "failed ingress tests"; }

# Run the integration tests
header "Running Go e2e tests"
go_test_e2e -timeout=20m ./test || failed=1
go_test_e2e -timeout=20m ./cmd/... || failed=1
go_test_e2e -timeout=20m ./test || { failed=1 && echo "failed integration tests"; }
go_test_e2e -timeout=20m ./cmd/... || { failed=1 && echo "failed integration tests"; }


header "Running examples tests"
$(dirname $0)/e2e-tests-examples.sh || failed=1
$(dirname $0)/e2e-tests-examples.sh || { failed=1 && echo "failed example tests"; }

(( failed )) && fail_test
success
Loading