Improve code consistency and fix missing test annotation#9266
Merged
tekton-robot merged 1 commit intotektoncd:mainfrom Dec 23, 2025
Merged
Improve code consistency and fix missing test annotation#9266tekton-robot merged 1 commit intotektoncd:mainfrom
tekton-robot merged 1 commit intotektoncd:mainfrom
Conversation
Use early returns in timeout handling for better code consistency and readability throughout the reconciliation logic. Add missing @test:execution=parallel annotation to the excessive reconciliation e2e test for proper test categorization. Addresses review feedback from PR tektoncd#9202.
tekton-robot
added
the
release-note-none
tekton-robot
added
the
size/XS
Member
Author
|
/kind cleanup |
tekton-robot
added
the
kind/cleanup
Collaborator
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Collaborator
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: twoGiants The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
This PR addresses review feedback from #9202:
Improve timeout handling consistency: Use early return pattern when
finallyWaitTime < waitTimeinstead of assigning to a temporary variable first. This makes the control flow more explicit and consistent with surrounding code in the reconciliation logic.Add missing test categorization annotation: Add
@test:execution=parallelannotation toTestPipelineRunExcessiveReconciliationso it's properly categorized by the test categorization system introduced in 9d89b01. Without this annotation, the test cannot be properly classified for parallel execution.Addresses review comments from #9202 (review)
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
/kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes