Skip to content

Improve code consistency and fix missing test annotation #9266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tekton-robot merged 1 commit into from
Dec 23, 2025
Merged

Improve code consistency and fix missing test annotation #9266

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pkg/reconciler/pipelinerun/pipelinerun.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -295,7 +295,7 @@ func (c *Reconciler) ReconcileKind(ctx context.Context, pr *v1.PipelineRun) pkgr
if timeout != config.NoTimeoutDuration {
waitTime := timeout - elapsed
if finallyWaitTime < waitTime {
waitTime = finallyWaitTime
return controller.NewRequeueAfter(finallyWaitTime)
}
return controller.NewRequeueAfter(waitTime)
}
Expand Down
3 changes: 3 additions & 0 deletions test/excessive_reconciliation_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,12 +59,15 @@ func getTektonNamespace() string {
// With the fix, reconciliations should stay well below 20 (typically around 10 or less).
//
// This test validates the fix by counting actual reconciliations from controller logs.
//
// @test:execution=parallel
func TestPipelineRunExcessiveReconciliation(t *testing.T) {
ctx := t.Context()
ctx, cancel := context.WithCancel(ctx)
defer cancel()

c, namespace := setup(ctx, t)
t.Parallel()

knativetest.CleanupOnInterrupt(func() { tearDown(ctx, t, c, namespace) }, t.Logf)
defer tearDown(ctx, t, c, namespace)
Expand Down
Loading