fix(codegen): Correct JSON tags for streaming lists #9240
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekton-robot
added
the
release-note-none
tekton-robot
added
the
size/S
Contributor
Author
|
/kind misc |
tekton-robot
added
the
kind/misc
Contributor
Author
|
/assign @vdemeester @afrittoli @waveywaves |
Contributor
Author
|
Refer this PR: https://github.com/tektoncd/pipeline/pull/9043/commits We had to fix this for codegen to work there. |
vdemeester
approved these changes
Dec 17, 2025
Collaborator
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
Member
|
/retest |
1 similar comment
Member
|
/retest |
Member
|
/retest |
The 'hack/update-codegen.sh' script was failing with 'streaming_list_type_json_tags' API rule violations. This was caused by incorrect JSON tags on list types that prevented them from being correctly interpreted as streaming lists by the Kubernetes API. This commit fixes the following: - Removes ',omitempty' from the 'Items' field in the v1 and v1beta1 PipelineRunList structs. - Adds ',omitempty' to the 'ListMeta' field in the v1beta1 ResolutionRequestList struct.
khrm
force-pushed
the
json-tag-stream
branch
from
d1fa4eb to
3a67bd7
Compare
Contributor
Author
|
LGTM got removed due to rebasing with main. @waveywaves @afrittoli Can you put it again? |
Member
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
The 'hack/update-codegen.sh' script is failing with 'streaming_list_type_json_tags' API rule violations when we update knative/pkg.
Refer: #9043
This was caused by incorrect JSON tags on list types that prevented them from being correctly interpreted as streaming lists by the Kubernetes API.
This commit fixes the following:
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
/kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes