feat(metrics): Migrate from OpenCensus to OpenTelemetry#9043
feat(metrics): Migrate from OpenCensus to OpenTelemetry#9043khrm wants to merge 7 commits intotektoncd:mainfrom
Conversation
|
The following is the coverage report on the affected files.
|
bab5a44 to
a2ea129
Compare
|
The following is the coverage report on the affected files.
|
|
The following is the coverage report on the affected files.
|
|
/retest |
|
The following is the coverage report on the affected files.
|
|
/retest |
|
Re knative bump, we discussed multiple times that we want knative/pkg@04fdd0b included in the next bump, even though it only exists in main for now (not even in 1.20). It'll unlock the better finalizer management which proved to be an issue for Tekton deployments with multiple controllers managing the same PR/TR resources. So do we want to bump knative/pkg even higher? |
|
/assign @vdemeester @waveywaves |
|
@enarha I have updated to latest knative/pkg for now. |
|
Why are ci tests being skipped? |
|
/kind feature |
|
@twoGiants @afrittoli Can you guys please review this? |
|
/retest |
|
/test pull-tekton-pipeline-go-coverage-df |
85c3c24 to
7df1705
Compare
|
@khrm I see in docs/metrics.md there is another metric named |
|
@divyansh42 It's there in the release note, isn't it? |
@khrm I just see two metrics |
This upgrades knative to latest and other dependent dependencies.
Replaces the legacy knative.dev/pkg/metrics dependency with knative.dev/pkg/observability/configmap to align with the OpenTelemetry migration and ensure correct configuration loading.
This isn't supported after knative otel's migration.
The knativetest.Flags.EmitMetrics flag is no longer supported after the migration to OpenTelemetry. This commit removes the conditional initialisation to align with the new metrics system.
Run hack/update-codegen.sh to update generated client code, deepcopy functions, and CRD manifests. This aligns the generated code with recent dependency updates, including changes to finalizer management and context usage in informers.
Update the expected checksums in Pipeline and Task unit tests to match the new values generated after the knative update: - pkg/apis/pipeline/v1 - pkg/apis/pipeline/v1beta1
This commit migrates the metrics for PipelineRuns and TaskRuns from
OpenCensus to OpenTelemetry.
The following changes are included:
- Updated the observability config to support OpenTelemetry.
- Migrated the implementation of PipelineRun and TaskRun metrics to use
the OpenTelemetry Go SDK.
- Updated the tests to work with the new OpenTelemetry-based
implementation.
|
e2e tests were failing due to this: |
Changes
pipelinerunmetricsandtaskrunmetricsto use OpenTelemetry instruments (histograms, counters, gauges) for creating and recording metrics.Introduced new OpenTelemetry configurations in
config/config-observability.yamlfor exporters and protocols..Rewrote the test suites for
pipelinerunmetricsandtaskrunmetricsto be compatible with the new OpenTelemetry-based implementation.fixes #8969
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
/kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes
/kind feature