Skip to content

Fix: CI job incorrectly skipped by file change detection#9238

Merged
tekton-robot merged 1 commit intotektoncd:mainfrom
khrm:ci-skip
Dec 16, 2025
Merged

Fix: CI job incorrectly skipped by file change detection#9238
tekton-robot merged 1 commit intotektoncd:mainfrom
khrm:ci-skip

Conversation

@khrm
Copy link
Contributor

@khrm khrm commented Dec 16, 2025

Changes

Updated the CI workflow to correctly detect changes in non-documentation and YAML files, preventing accidental skips of the CI job.

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
  • Has Tests included if any functionality added or changed
  • pre-commit Passed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

@tekton-robot tekton-robot added the release-note-none Denotes a PR that doesnt merit a release note. label Dec 16, 2025
@tekton-robot tekton-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Dec 16, 2025
Copy link
Contributor Author

@khrm khrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@khrm
Copy link
Contributor Author

khrm commented Dec 16, 2025

/kind misc

@tekton-robot tekton-robot added the kind/misc Categorizes issue or PR as a miscellaneuous one. label Dec 16, 2025
@khrm
Copy link
Contributor Author

khrm commented Dec 16, 2025

You can check here: https://github.com/tektoncd/pipeline/actions/runs/20254914509/job/58154721153

Previous change wasn't working there.

@khrm
Copy link
Contributor Author

khrm commented Dec 16, 2025

/assign @twoGiants

@vdemeester
Copy link
Member

/approve

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 16, 2025
Updated the CI workflow to correctly detect changes in non-documentation
and YAML files, preventing accidental skips of the CI job.
Copy link
Member

@afrittoli afrittoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 16, 2025
@khrm
Copy link
Contributor Author

khrm commented Dec 16, 2025

/retest

1 similar comment
@khrm
Copy link
Contributor Author

khrm commented Dec 16, 2025

/retest

@khrm
Copy link
Contributor Author

khrm commented Dec 16, 2025

@waveywaves @vdemeester Can you please add retest here?

@vdemeester
Copy link
Member

/retest

@tekton-robot tekton-robot merged commit 40090b5 into tektoncd:main Dec 16, 2025
20 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/misc Categorizes issue or PR as a miscellaneuous one. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesnt merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

6 participants