.github/workflows: fix e2e-matrix-extras #9185
Conversation
The problem was that the workflow was trying to use context.issue.number and github.event.issue.number, which aren't available in repository_dispatch events. Signed-off-by: Vincent Demeester <[email protected]>
tekton-robot
added
kind/misc
tekton-robot
added
the
size/XS
|
@vdemeester: GitHub didn't allow me to request PR reviews from the following users: AlanGreene. Note that only tektoncd members and repo collaborators can review this PR, and authors cannot review their own PRs. DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
| owner: context.repo.owner, | ||
| repo: context.repo.repo, | ||
| pull_number: context.issue.number | ||
| pull_number: ${{ github.event.client_payload.github.payload.issue.number }} |
There was a problem hiding this comment.
I guess I could use context.payload.client_payload.github.payload.issue.number as well
|
/e2e-extras |
|
Something went wrong with your [1]: |
|
Uhm, when routing commands, it doesn't pick up the version of the workflow from the PR, which makes it a problem for testing the slash commands themselves. We'll test it once it's merged. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: afrittoli, twoGiants The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
Yeah.. it's a bit a shot in the dark. If it fails again, I'll replicate this on my workflow-experiments repo to figure out what happens. |
|
/retest |
5 participants
Changes
The problem was that the workflow was trying to use
context.issue.number and github.event.issue.number, which aren't
available in repository_dispatch events.
Signed-off-by: Vincent Demeester [email protected]
/kind misc
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
/kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes