Skip to content

Migrate tests images out of dockerhub.#9158

Merged
tekton-robot merged 1 commit intotektoncd:mainfrom
vdemeester:4551-remove-dockerhub-reference
Dec 1, 2025
Merged

Migrate tests images out of dockerhub.#9158
tekton-robot merged 1 commit intotektoncd:mainfrom
vdemeester:4551-remove-dockerhub-reference

Conversation

@vdemeester
Copy link
Member

Changes

Let's try to complete this migration.

Closes #4551.

Signed-off-by: Vincent Demeester [email protected]

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
  • Has Tests included if any functionality added or changed
  • pre-commit Passed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

@tekton-robot tekton-robot added the release-note-none Denotes a PR that doesnt merit a release note. label Nov 20, 2025
@tekton-robot tekton-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 20, 2025
@vdemeester
Copy link
Member Author

/kind cleanup

@tekton-robot tekton-robot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Nov 20, 2025
@vdemeester
Copy link
Member Author

/retest

1 similar comment
@vdemeester
Copy link
Member Author

/retest

@vdemeester
Copy link
Member Author

/e2e-extras

1 similar comment
@vdemeester
Copy link
Member Author

/e2e-extras

@tekton-robot
Copy link
Collaborator

Something went wrong with your /e2e-extras command: [please check the logs][1].

[1]:

@afrittoli
Copy link
Member

Something went wrong with your /e2e-extras command: [please check the logs

Uhm... the log was not very verbose :P

@afrittoli
Copy link
Member

/e2e-extras

@tekton-robot
Copy link
Collaborator

Something went wrong with your /e2e-extras command: [please check the logs][1].

[1]:

@afrittoli
Copy link
Member

@AlanGreene
Copy link
Member

I don't think context.issue.number is available on repository_dispatch events, instead we'd need to use the relevant github.event.* value

https://github.com/tektoncd/pipeline/actions/runs/19734381717/workflow#L35

@afrittoli
Copy link
Member

I don't think context.issue.number is available on repository_dispatch events, instead we'd need to use the relevant github.event.* value

https://github.com/tektoncd/pipeline/actions/runs/19734381717/workflow#L35

Yeah, the PR number is missing:

RequestError [HttpError]: Not Found
    at /home/runner/work/_actions/actions/github-script/60a0d83039c74a4aee543508d2ffcb1c3799cdea/dist/index.js:9537:21
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
    at async eval (eval at callAsyncFunction (/home/runner/work/_actions/actions/github-script/60a0d83039c74a4aee543508d2ffcb1c3799cdea/dist/index.js:35424:16), <anonymous>:3:12)
    at async main (/home/runner/work/_actions/actions/github-script/60a0d83039c74a4aee543508d2ffcb1c3799cdea/dist/index.js:35522:20) {
  status: 404,
  response: {
    url: 'https://api.github.com/repos/tektoncd/pipeline/pulls/',
    status: 404,

@vdemeester
Copy link
Member Author

arf, I need to fix this

@vdemeester
Copy link
Member Author

I don't think context.issue.number is available on repository_dispatch events, instead we'd need to use the relevant github.event.* value
https://github.com/tektoncd/pipeline/actions/runs/19734381717/workflow#L35

Yeah, the PR number is missing:

RequestError [HttpError]: Not Found
    at /home/runner/work/_actions/actions/github-script/60a0d83039c74a4aee543508d2ffcb1c3799cdea/dist/index.js:9537:21
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
    at async eval (eval at callAsyncFunction (/home/runner/work/_actions/actions/github-script/60a0d83039c74a4aee543508d2ffcb1c3799cdea/dist/index.js:35424:16), <anonymous>:3:12)
    at async main (/home/runner/work/_actions/actions/github-script/60a0d83039c74a4aee543508d2ffcb1c3799cdea/dist/index.js:35522:20) {
  status: 404,
  response: {
    url: 'https://api.github.com/repos/tektoncd/pipeline/pulls/',
    status: 404,

I think #9185 should fix it 👼🏼

Copy link
Member

@twoGiants twoGiants left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm
/meow

@tekton-robot
Copy link
Collaborator

@twoGiants: cat image

Details

In response to this:

/approve
/lgtm
/meow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 1, 2025
Copy link
Member

@afrittoli afrittoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!
/approve

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afrittoli, twoGiants

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 1, 2025
@tekton-robot tekton-robot merged commit b03f7e4 into tektoncd:main Dec 1, 2025
64 of 72 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesnt merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Move off DockerHub for e2e images

5 participants