This repository was archived by the owner on Nov 14, 2019. It is now read-only.
Fixed some issues for the self-update command #276
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smatyas
force-pushed
the
improving-self-update-errors
branch
from
c61de7c to
d9fe40b
Compare
…rollback message, set return code at general exception handling, fixed an undefined variable notice.
smatyas
force-pushed
the
improving-self-update-errors
branch
from
d9fe40b to
ab6cce2
Compare
|
@smatyas it took us some time ... but this is finally merged! thanks for working on it. |
javiereguiluz
added a commit
that referenced
this pull request
Sep 30, 2016
This PR was merged into the 1.0-dev branch. Discussion ---------- Fixed some issues for the self-update command Currently, the `self-update` command does not return an alerting enough exit message or status code on permission errors. I saw in the code that it was intended, but it did not work well enough. This PR fixes this issue by modifying the thrown exception type in certain cases, and by making the fallback exception to return error code 1, and by coloring the rollback message. Before:  After:  Commits ------- ab6cce2 Fixed some issues for the self-update command: added coloring to the rollback message, set return code at general exception handling, fixed an undefined variable notice.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the
self-updatecommand does not return an alerting enough exit message or status code on permission errors.I saw in the code that it was intended, but it did not work well enough.
This PR fixes this issue by modifying the thrown exception type in certain cases, and by making the fallback exception to return error code 1, and by coloring the rollback message.
Before:
After:
