Fixed some issues for the self-update command: added coloring to the rollback message, set return code at general exception handling, fixed an undefined variable notice.

Author: smatyas

src/Symfony/Installer/DownloadCommand.php

@@ -520,6 +520,7 @@ protected function getExecutedCommand()
         }
 
         $commandName = $this->getName();
+        $commandArguments = '';
 
         if ('new' === $commandName) {
             $commandArguments = sprintf('%s %s', $this->projectName, ('latest' !== $this->version) ? $this->version : '');

src/Symfony/Installer/SelfUpdateCommand.php

@@ -136,6 +136,8 @@ protected function execute(InputInterface $input, OutputInterface $output)
             if ($this->output->isVeryVerbose()) {
                 $this->output->writeln($e->getMessage());
             }
+
+            return 1;
         }
     }
 
@@ -148,11 +150,11 @@ private function downloadNewVersion()
     {
         // check for permissions in local filesystem before start downloading files
         if (!is_writable($this->currentInstallerFile)) {
-            throw new \RuntimeException('Symfony Installer update failed: the "'.$this->currentInstallerFile.'" file could not be written');
+            throw new IOException('Symfony Installer update failed: the "'.$this->currentInstallerFile.'" file could not be written');
         }
 
         if (!is_writable($this->tempDir)) {
-            throw new \RuntimeException('Symfony Installer update failed: the "'.$this->tempDir.'" directory used to download files temporarily could not be written');
+            throw new IOException('Symfony Installer update failed: the "'.$this->tempDir.'" directory used to download files temporarily could not be written');
         }
 
         if (false === $newInstaller = $this->getUrlContents($this->remoteInstallerFile)) {
@@ -225,7 +227,7 @@ private function rollback()
     {
         $this->output->writeln(array(
             '',
-            'There was an error while updating the installer.',
+            '<error>There was an error while updating the installer.</error>',
             'The previous Symfony Installer version has been restored.',
             '',
         ));