Skip to content
This repository was archived by the owner on Nov 14, 2019. It is now read-only.

Moved the version in DownloadCommand #205

Closed
wants to merge 4 commits into from
Closed

Moved the version in DownloadCommand #205

wants to merge 4 commits into from

Conversation

Pierstoval
Copy link
Contributor

This fixes #204

@ogizanagi
Copy link
Contributor

👍 Always wondered why it was like it. BTW, you could also move $downloadedFilePath and $requirementsErrors IMO.

Also, it makes no sense the DownloadCommand has methods with @return NewCommand in the PhpDoc block and deals bad with IDE autocompletion (should be @return $this).

Those were the changes I was going to push : master...ogizanagi:move_to_download
Feel free to integrate them if it makes sense to you.

@Pierstoval
Copy link
Contributor Author

@ogizanagi done :)

@javiereguiluz
Copy link
Member

@Pierstoval thanks for providing such a fast bugfix!

@ogizanagi ogizanagi mentioned this pull request Nov 30, 2015
Merged
javiereguiluz added a commit that referenced this pull request Dec 1, 2015
@javiereguiluz
minor #209 Remove unnecessary properties (ogizanagi)
9a52ae8 
This PR was merged into the 1.0-dev branch.

Discussion
----------

Remove unnecessary properties

Those properties have been moved to the `DownloadCommand` in #205

Commits
-------

1dd265d Remove unnecessary properties
@Pierstoval Pierstoval deleted the fix_204 branch December 14, 2015 13:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
bug FINISHED
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Issue when installing the Symfony Demo with the latest Installer version
3 participants
@Pierstoval @ogizanagi @javiereguiluz