bug #205 Moved the version in DownloadCommand (Pierstoval)

This PR was squashed before being merged into the 1.0-dev branch (closes #205).

Discussion
----------

Moved the version in DownloadCommand

This fixes #204

Commits
-------

8e7572d Moved the version in DownloadCommand

Author: javiereguiluz

src/Symfony/Installer/DownloadCommand.php

@@ -36,13 +36,41 @@
  */
 abstract class DownloadCommand extends Command
 {
-    /** @var Filesystem */
+    /**
+     * @var Filesystem
+     */
     protected $fs;
-    /** @var OutputInterface */
+
+    /**
+     * @var OutputInterface
+     */
     protected $output;
+
+    /**
+     * @var string
+     */
     protected $projectName;
+
+    /**
+     * @var string
+     */
     protected $projectDir;
 
+    /**
+     * @var string
+     */
+    protected $version;
+
+    /**
+     * @var string
+     */
+    protected $downloadedFilePath;
+
+    /**
+     * @var array
+     */
+    protected $requirementsErrors = array();
+
     /**
      * Returns the type of the downloaded application in a human readable format.
      * It's mainly used to display readable error messages.
@@ -62,14 +90,16 @@ protected function initialize(InputInterface $input, OutputInterface $output)
         $this->fs = new Filesystem();
 
         $this->enableSignalHandler();
+
+        $this->version = $input->hasArgument('version') ? trim($input->getArgument('version')) : 'latest';
     }
 
     /**
      * Chooses the best compressed file format to download (ZIP or TGZ) depending upon the
      * available operating system uncompressing commands and the enabled PHP extensions
      * and it downloads the file.
      *
-     * @return Command
+     * @return $this
      *
      * @throws \RuntimeException if the Symfony archive could not be downloaded
      */
@@ -200,7 +230,7 @@ protected function getGuzzleClient()
      * Extracts the compressed Symfony file (ZIP or TGZ) using the
      * native operating system commands if available or PHP code otherwise.
      *
-     * @return NewCommand
+     * @return DownloadCommand
      *
      * @throws \RuntimeException if the downloaded archive could not be extracted
      */
@@ -256,7 +286,7 @@ protected function extract()
     /**
      * Checks if environment meets symfony requirements.
      *
-     * @return Command
+     * @return $this
      */
     protected function checkSymfonyRequirements()
     {
@@ -280,7 +310,7 @@ protected function checkSymfonyRequirements()
     /**
      * Creates the appropriate .gitignore file for a Symfony project.
      *
-     * @return Command
+     * @return $this
      */
     protected function createGitIgnore()
     {
@@ -438,7 +468,7 @@ protected function isEmptyDirectory($dir)
      */
     protected function isSymfony3()
     {
-        return '3' === $this->version[0];
+        return $this->version && '3' === $this->version[0];
     }
 
     private function enableSignalHandler()

src/Symfony/Installer/NewCommand.php

@@ -24,10 +24,6 @@
  */
 class NewCommand extends DownloadCommand
 {
-    protected $version;
-    protected $downloadedFilePath;
-    protected $requirementsErrors = array();
-
     protected function configure()
     {
         $this
@@ -45,7 +41,6 @@ protected function initialize(InputInterface $input, OutputInterface $output)
         $directory = rtrim(trim($input->getArgument('directory')), DIRECTORY_SEPARATOR);
         $this->projectDir = $this->fs->isAbsolutePath($directory) ? $directory : getcwd().DIRECTORY_SEPARATOR.$directory;
         $this->projectName = basename($directory);
-        $this->version = trim($input->getArgument('version'));
     }
 
     protected function execute(InputInterface $input, OutputInterface $output)