Skip to content

[5.9][Macros] Update help message for '-load-plugin-executable' #67835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

rintaro
Copy link
Member

@rintaro rintaro commented Aug 9, 2023

Cherry-pick #67834 into release/5.9

  • Explanation: -load-plugin-executable compiler option is the primary supported way of using macro plugin. SwiftPM uses this when developers use .macro() target. The help text should clarify the format and the semantics of the arguments.
  • Scope: Help message for -h
  • Risk: Low, this is just a message change
  • Testing: Passes current test suite
  • Issues: rdar://113646544
  • Reviewer: Ben Barham (@bnbarham)

Clarify the format of the option and semantics.

rdar://113646544
(cherry picked from commit 8aa277e)
@rintaro rintaro requested a review from a team as a code owner August 9, 2023 20:44
@rintaro rintaro changed the title [Macros] Update help message for '-load-plugin-executable' [5.9][Macros] Update help message for '-load-plugin-executable' Aug 9, 2023
@rintaro
Copy link
Member Author

rintaro commented Aug 9, 2023

@swift-ci Please test

@rintaro rintaro merged commit 7062f6f into swiftlang:release/5.9 Sep 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants