Revert "[IRGen] Put 'ret void' instead of unreachable for non swiftasync cc" #40446
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test Windows platform |
kateinoigakukun
approved these changes
Dec 7, 2021
There was a problem hiding this comment.
For the record, test/IRGen/async/hop_to_executor.sil failed
https://ci-external.swift.org/job/oss-swift-windows-toolchain-x86_64-vs2019/439/console
|
If #40448 passes (which it should as I tested it locally), we should prefer that over this. This just verified that this failure was caused by that change. Given that it has a head start over this change, I don't think it makes sense to merge this and might as well as fix forward. |
|
Windows passed with this revert, so that was the cause... but let's hope #40448 passes so we don't need this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #39680
I think that this might have regressed the Windows CI; the change itself is relevant to Windows as well as the TCO path in PEI is unsupported ATM :-(.