Skip to content

[6.2] Fix a crash if we had a dollar identifier as the second parameter label in a closure not followed by a colon #3108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 18, 2025

Conversation

hamishknight
Copy link
Contributor

6.2 cherry-pick of #3104

  • Explanation: Fixes a crash that could occur when attempting to parse a malformed closure signature
  • Scope: Affects type parsing
  • Issue: rdar://153525458, Parser crashes on invalid type signature in closure #3103
  • Risk: Low, the fix is straightforward
  • Testing: Added tests to test suite
  • Reviewer: Hamish Knight, Ben Barham

…el in a closure not followed by a colon

There was a mismatch between the call to `eat` and `at`. Switch the pair to a `consume(if:)` to avoid the issue.

Fixes swiftlang#3103
@hamishknight hamishknight requested a review from bnbarham June 18, 2025 15:19
@hamishknight hamishknight requested a review from a team as a code owner June 18, 2025 15:19
@hamishknight
Copy link
Contributor Author

@swift-ci please test

@hamishknight hamishknight merged commit fd6373f into swiftlang:release/6.2 Jun 18, 2025
28 checks passed
@hamishknight hamishknight deleted the 3104-6.2 branch June 18, 2025 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants