Fix a crash if we had a dollar identifier as the second parameter label in a closure not followed by a colon #3104
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…el in a closure not followed by a colon There was a mismatch between the call to `eat` and `at`. Switch the pair to a `consume(if:)` to avoid the issue. Fixes swiftlang#3103
|
@swift-ci Please test |
hamishknight
approved these changes
Jun 16, 2025
bnbarham
approved these changes
Jun 16, 2025
|
@swift-ci please test Windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a mismatch between the call to
eatandat. Switch the pair to aconsume(if:)to avoid the issue.Fixes #3103