Skip to content

chore: Test array sort in effect #16175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,52 @@
import { flushSync } from 'svelte';
import { test } from '../../test';

export default test({
/**
* Ensure that sorting an array inside an $effect works correctly
* and re-runs when the array changes (e.g., when items are added).
*/
test({ assert, target }) {
const button = target.querySelector('button');

// initial render — array should be sorted
assert.htmlEqual(
target.innerHTML,
`
<button>add item</button>
<p>0</p>
<p>50</p>
<p>100</p>
`
);

// add first item (20); effect should re-run and sort the array
flushSync(() => button?.click());

assert.htmlEqual(
target.innerHTML,
`
<button>add item</button>
<p>0</p>
<p>20</p>
<p>50</p>
<p>100</p>
`
);

// add second item (80); effect should re-run and sort the array
flushSync(() => button?.click());

assert.htmlEqual(
target.innerHTML,
`
<button>add item</button>
<p>0</p>
<p>20</p>
<p>50</p>
<p>80</p>
<p>100</p>
`
);
}
});
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
<script>
let arr = $state([100, 0, 50]);
let nextValues = [20, 80];
let valueIndex = 0;

$effect(() => {
arr.sort((a, b) => a - b);
});

function addItem() {
if (valueIndex < nextValues.length) {
arr.push(nextValues[valueIndex]);
valueIndex++;
}
}
</script>

<button onclick={addItem}>add item</button>
{#each arr as x}
<p>{x}</p>
{/each}