Skip to content

chore: Test array sort in effect #16175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

raythurnvoid
Copy link
Contributor

While working on #16161 to address #16092 I introduced a regression, however no test was failing.

This test would have failed and prevented me from opening the PR

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.
  • If this PR changes code within packages/svelte/src, add a changeset (npx changeset).

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

Copy link

changeset-bot bot commented Jun 15, 2025

⚠️ No Changeset found

Latest commit: 58b4b84

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@svelte-docs-bot
Copy link

@raythurnvoid raythurnvoid force-pushed the chore/@sveltejs/svelte/test-array-sort-in-effect branch from f807789 to 58b4b84 Compare June 15, 2025 23:55
Copy link
Contributor

Playground

pnpm add https://pkg.pr.new/svelte@16175

Copy link
Member

@Rich-Harris Rich-Harris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you know... it never occurred to me that sorting inside an effect wouldn't result in an infinite loop because nothing is actually changing on the second run following an update. that's interesting and cool. thanks!

@Rich-Harris Rich-Harris merged commit de90fc8 into sveltejs:main Jun 17, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants