Simplifies tempo importing #1568
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Imports tempo for new projects, otherwise asks the user.
stakira
requested review from
Copilot and
oxygen-dioxide
and removed request for
Copilot
Contributor
There was a problem hiding this comment.
Pull Request Overview
Simplifies tempo importing by removing the old static preference and instead auto-importing tempos for brand‐new projects while prompting the user for existing ones.
- Removed the “ImportTempo” setting and UI controls from preferences.
- Updated the import-tracks workflow to infer default behavior and ask only when needed.
- Cleaned up related string resources and preference storage.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| OpenUtau/Views/PreferencesDialog.axaml | Removed Import Tempo combo box and label |
| OpenUtau/Views/MainWindow.axaml.cs | Replaced ImportTempo setting logic with auto/prompt |
| OpenUtau/ViewModels/PreferencesViewModel.cs | Deleted ImportTempo property and subscriptions |
| OpenUtau/Strings/Strings.axaml | Removed unused import-tempo string resources |
| OpenUtau.Core/Util/Preferences.cs | Deleted ImportTempo field from serializable prefs |
Comments suppressed due to low confidence (1)
OpenUtau/Views/MainWindow.axaml.cs:324
- Consider adding unit tests for the new tempo-import logic to verify behavior for new projects, existing projects without tempos, and existing projects with tempos.
bool importTempo = DocManager.Inst.Project.parts.Count == 0;
lottev1991
pushed a commit
to lottev1991/OpenUtau
that referenced
this pull request
Jun 6, 2025
Imports tempo for new projects, otherwise asks the user.
lottev1991
added a commit
to lottev1991/OpenUtau
that referenced
this pull request
Jun 8, 2025
This reverts commit 2f93ec4.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Imports tempo for new projects, otherwise asks the user.