Simplifies tempo importing (stakira#1568)

Imports tempo for new projects, otherwise asks the user.

Author: stakira

OpenUtau.Core/Util/Preferences.cs

@@ -188,7 +188,6 @@ public class SerializablePreferences {
             public bool RememberMid = false;
             public bool RememberUst = true;
             public bool RememberVsqx = true;
-            public int ImportTempo = 0;
             public string PhoneticAssistant = string.Empty;
             public string RecentOpenSingerDirectory = string.Empty;
             public string RecentOpenProjectDirectory = string.Empty;

OpenUtau/Strings/Strings.axaml

@@ -371,10 +371,6 @@ Warning: this option removes custom presets.</system:String>
 
   <system:String x:Key="prefs.advanced">Advanced</system:String>
   <system:String x:Key="prefs.advanced.beta">Beta</system:String>
-  <system:String x:Key="prefs.advanced.importtempo">When importing tracks, use the tempos of the imported project</system:String>
-  <system:String x:Key="prefs.advanced.importtempo.always">Always</system:String>
-  <system:String x:Key="prefs.advanced.importtempo.ask">Ask me each time</system:String>
-  <system:String x:Key="prefs.advanced.importtempo.never">Never</system:String>
   <system:String x:Key="prefs.advanced.lyricshelper">Lyrics Helper</system:String>
   <system:String x:Key="prefs.advanced.lyricshelper.brackets">Lyrics Helper Adds Brackets</system:String>
   <system:String x:Key="prefs.advanced.rememberfiletypes">Remember these file types in "Open Recent"</system:String>

OpenUtau/ViewModels/PreferencesViewModel.cs

@@ -100,7 +100,6 @@ public override string ToString() {
         [Reactive] public bool RememberMid{ get; set; }
         [Reactive] public bool RememberUst{ get; set; }
         [Reactive] public bool RememberVsqx{ get; set; }
-        [Reactive] public int ImportTempo{ get; set; }
 
         private List<AudioOutputDevice>? audioOutputDevices;
         private AudioOutputDevice? audioOutputDevice;
@@ -167,7 +166,6 @@ public PreferencesViewModel() {
             RememberMid = Preferences.Default.RememberMid;
             RememberUst = Preferences.Default.RememberUst;
             RememberVsqx = Preferences.Default.RememberVsqx;
-            ImportTempo = Preferences.Default.ImportTempo;
             ClearCacheOnQuit = Preferences.Default.ClearCacheOnQuit;
 
             this.WhenAnyValue(vm => vm.AudioOutputDevice)
@@ -326,11 +324,6 @@ public PreferencesViewModel() {
                     Preferences.Default.RememberVsqx = index;
                     Preferences.Save();
                 });
-            this.WhenAnyValue(vm => vm.ImportTempo)
-                .Subscribe(index => {
-                    Preferences.Default.ImportTempo = index;
-                    Preferences.Save();
-                });
             this.WhenAnyValue(vm => vm.ClearCacheOnQuit)
                 .Subscribe(index => {
                     Preferences.Default.ClearCacheOnQuit = index;

OpenUtau/Views/MainWindow.axaml.cs

@@ -320,30 +320,20 @@ async void OnMenuImportTracks(object sender, RoutedEventArgs args) {
                 if (loadedProjects == null || loadedProjects.Length == 0) {
                     return;
                 }
-                bool importTempo = true;
-                switch (Preferences.Default.ImportTempo) {
-                    case 1:
-                        importTempo = false;
-                        break;
-                    case 2:
-                        if (loadedProjects[0].tempos.Count == 0) {
-                            importTempo = false;
-                            break;
-                        }
-                        var tempoString = String.Join("\n",
-                            loadedProjects[0].tempos
-                                .Select(tempo => $"position: {tempo.position}, tempo: {tempo.bpm}")
-                            );
-                        //ask the user
-                        var result = await MessageBox.Show(
-                            this,
-                            ThemeManager.GetString("dialogs.importtracks.importtempo") + "\n" + tempoString,
-                            ThemeManager.GetString("dialogs.importtracks.caption"),
-                            MessageBox.MessageBoxButtons.YesNo);
-                        if (result == MessageBox.MessageBoxResult.No) {
-                            importTempo = false;
-                        }
-                        break;
+                // Imports tempo for new projects, otherwise asks the user.
+                bool importTempo = DocManager.Inst.Project.parts.Count == 0;
+                if (!importTempo && loadedProjects[0].tempos.Count > 0) {
+                    var tempoString = string.Join("\n",
+                        loadedProjects[0].tempos
+                            .Select(tempo => $"position: {tempo.position}, tempo: {tempo.bpm}")
+                        );
+                    // Ask the user
+                    var result = await MessageBox.Show(
+                        this,
+                        ThemeManager.GetString("dialogs.importtracks.importtempo") + "\n" + tempoString,
+                        ThemeManager.GetString("dialogs.importtracks.caption"),
+                        MessageBox.MessageBoxButtons.YesNo);
+                    importTempo = result == MessageBox.MessageBoxResult.Yes;
                 }
                 viewModel.ImportTracks(loadedProjects, importTempo);
             } catch (Exception e) {
@@ -626,7 +616,7 @@ async void OnMenuInstallWavtoolResampler(object sender, RoutedEventArgs args) {
             if (file == null) {
                 return;
             }
-            
+
             if (file.EndsWith(".exe")) {
                 var setup = new ExeSetupDialog() {
                     DataContext = new ExeSetupViewModel(file)

OpenUtau/Views/PreferencesDialog.axaml

@@ -290,12 +290,6 @@
             <CheckBox IsChecked="{Binding RememberVsqx}" Grid.Column="0" Grid.Row="2" VerticalAlignment="Center"/>
             <TextBlock Text=" .vsqx" Grid.Column="1" Grid.Row="2" VerticalAlignment="Center"/>
           </Grid>
-          <TextBlock Text="{DynamicResource prefs.advanced.importtempo}" Margin="0,10,0,0"/>
-          <ComboBox SelectedIndex="{Binding ImportTempo}">
-            <ComboBoxItem Content="{DynamicResource prefs.advanced.importtempo.always}"/>
-            <ComboBoxItem Content="{DynamicResource prefs.advanced.importtempo.never}"/>
-            <ComboBoxItem Content="{DynamicResource prefs.advanced.importtempo.ask}"/>
-          </ComboBox>
         </StackPanel>
       </Carousel>
     </ScrollViewer>