INT-4574: JDBC: Add NOT NULL for primary keys #2698
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JIRA: https://jira.spring.io/browse/INT-4574 Some RDBMS don't allow have nullable columns for primary keys * Add NOT NULL for all the columns involved in primary keys **Cherry-pick to 4.3.x**
garyrussell
reviewed
Jan 14, 2019
| -- This is only needed if the message group store property 'priorityEnabled' is true | ||
| -- CREATE UNIQUE INDEX INT_CHANNEL_MSG_PRIORITY_IDX ON INT_CHANNEL_MESSAGE (REGION, GROUP_KEY, MESSAGE_PRIORITY DESC, CREATED_DATE, MESSAGE_SEQUENCE); | ||
| CREATE INDEX INT_CHANNEL_MSG_DATE_IDX ON INT_CHANNEL_MESSAGE (CREATED_DATE, MESSAGE_SEQUENCE); | ||
| CREATE INDEX INT_CHANNEL_MSG_PRIORITY_IDX ON INT_CHANNEL_MESSAGE (MESSAGE_PRIORITY DESC, CREATED_DATE, MESSAGE_SEQUENCE); |
There was a problem hiding this comment.
Why changes to this table here, but not on master?
There was a problem hiding this comment.
Oh! this must not be here. The problem is with vpp .We Don't have it on master any more.
Will fix it later here.
We must keep your index here.
|
Restored all the previous state of scripts with the fix for VPP template. Let me know if this doesn't back-port to 4.3.x properly. We don't have VPP on master after this: f970bf0 |
|
Cherry-pick is not clean because the channel tables are in separate files; please backport; thanks. |
artembilan
added a commit
that referenced
this pull request
Jan 15, 2019
* INT-4574: JDBC: Add NOT NULL for primary keys JIRA: https://jira.spring.io/browse/INT-4574 Some RDBMS don't allow have nullable columns for primary keys * Add NOT NULL for all the columns involved in primary keys **Cherry-pick to 4.3.x** * * Include index generation into the `schema.sql.vpp` * * Remove redundant blank line from generated scripts * * Fix INT_CHANNEL_MESSAGE primary generation # Conflicts: # spring-integration-jdbc/src/main/resources/org/springframework/integration/jdbc/schema-mysql.sql # spring-integration-jdbc/src/main/resources/org/springframework/integration/jdbc/schema-oracle.sql # spring-integration-jdbc/src/main/sql/schema.sql.vpp
|
Back-ported to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: https://jira.spring.io/browse/INT-4574
Some RDBMS don't allow have nullable columns for primary keys
Cherry-pick to 4.3.x